AD review: draft-ietf-adslmib-adsl2-04.txt

Sorry that it took so long to review.

Here is what I get from SMICng: 

   E: f(adsl2.mi2), (3689,16) Index item "adsl2PMLHist15MInterval"
      must be defined with syntax that includes a range
   E: f(adsl2.mi2), (3833,16) Index item "adsl2PMLHist1DInterval"
      must be defined with syntax that includes a range
   E: f(adsl2.mi2), (3977,16) Index item "adsl2PMLHistInit15MInterval"
      must be defined with syntax that includes a range
   E: f(adsl2.mi2), (4083,16) Index item "adsl2PMLHistinit1DInterval"
      must be defined with syntax that includes a range
   E: f(adsl2.mi2), (4348,16) Index item "adsl2PMChHist15MInterval"
      must be defined with syntax that includes a range
   E: f(adsl2.mi2), (4451,16) Index item "adsl2PMChHist1DInterval"
      must be defined with syntax that includes a range

Not sure I understand why you did not inlcude such a range?

I see:
   ngdslTCMIB MODULE-IDENTITY
         ::= { transmission xxx }
   -- RFC Ed.: we suggest to put it under { transmission 230 } because
   --          this is the first available number.
and I also see:
   ngdslMIB MODULE-IDENTITY
         ::= { transmission xxx }
   -- RFC Ed.: we suggest to put it under { transmission 231 } because
   --          this is the first available number.

Now if you go to http://www.iana.org/assignments/ianaiftype-mib
then you will see that 231 and 232 have been taken by now.
So asking for 231 does not make sense (anymore).
But besides, I see that you have gotten 230 assigned for adsl2.
So it seems weird to me to then askl it to be used for the TC MIB module.

For RFC2662, I see that we also had a TC and that we had 
   adsltcmib MODULE-IDENTITY
      ::= { transmission 94 2 } -- adslMIB 2
And 
   adslMIB MODULE-IDENTITY
   ::= { transmission 94 }

   adslLineMib OBJECT IDENTIFIER ::= { adslMIB 1 }

So we could follow a similar approach here.

Then (I do not recall if you answered this earlier) I wonder that
the IfType is adsl2, but we root the ngdslMIB underneath it.
I understand (from wg mail discussion) that this new MIB module is
also to address the ngdsl and vdsl2 in the future.
Is the plan to have a vdsl2 ifType in the future? If so, how does that
fit with this MIB document?

We then use ngdls as the MIB module name and adsl2 as prefix for 
all objects. Not very consistent is it?

The reason I get a bot confused is this:
- abstract says:
   This document defines a Management Information Base (MIB) module for
   use with network management protocols in the Internet community.  In
   particular, it describes objects used for managing parameters of the
   "Asymmetric Digital Subscriber Line" family of interface types,
   especially including ADSL, ADSL2, and ADSL2+.
- And then the first table DESCRIPTION states:
   adsl2LineTable  OBJECT-TYPE
      SYNTAX      SEQUENCE  OF  Adsl2LineEntry
      MAX-ACCESS  not-accessible
      STATUS      current
      DESCRIPTION
         "The table adsl2LineTable contains configuration,
          command and status parameters of the ADSL2 line.
          The index of this table is an interface index where the
          interface has an ifType of adsl2(230)."
- So will ifTypes with ifType adsl also be in this table?
  Can they be in this table? MUST they be in this table?

I see read-create table(s) like adsl2LineConfTemplateTable and
adsl2LineConfProfTable but nowhere can I find what the persistency
behaviour is of the rows in these tables. Pls check all writable
objects and tables and make sure you describe the expected persistency
behaviour and/or use StorageType objects (RFC2579) for tables.

In your RowStatus object DESCRIPTION clauses I see:

         Before a profile can be deleted or taken out of service
         (by setting this object to 'destroy' or 'outOfService'),
         it must be first unreferenced from all associated
         lines."

I think you mean notInService instead of outOfService, see RFC2579.

You must also state whihc objects if any can or cannot be changed
if a row is active.

I need to study this more and better before I can complete my review.

Bert