Comments on the Protocol version 10

Evangelos Haleplidis <[email protected]> Wed, 13 Jun 2007 21:34:33 +0300
Newsgroups gmane.ietf.forces
Message-ID <001a01c7ade9$7df87a90$0501a8c0@gaglaptop>
Greetings to the list,

I was reading the protocol draft-10, and i have some
comments/questions/editorials.

Regards,

Evangelos Haleplidis

=============================
Editorials:

E1. Page 10: 
LFB(Logical Function Block) and LFB Instance - ...

Since LFB's have been introduced before, and that section is about class and
instance I think this should be changed to:

LFB Class and LFB Instance

E2. Page 11:
In the text regarding the pre-association Phase, there are two parenthesis
(see below). I believe they should be erased.

E3. Page 23:
... the FE MUST only validates that ...
-----------------------------^
Should be changed to:
... the FE MUST only validate that ...

E4. Page 37:
In the NoACK section:

... MUST not to send ....
--------------^
Should be changed to:
... MUST not send

E5. Page 51:
In the comments regarging SET-PROP
... or update attributes.
Should be changed to:
... or update attribute properties.

E6. Pages 72 & 74.
The figures have some errors.

E7. Pages 65, 69, 71, 72, 74, 75, 77, 78, 
The figures lack numbers on top of them.

=============================
Comments:

C1. Page 61:
In the FE Protocol LFB the LFB Class ID is assigned the value 0x1. In the
model draft (page 82) it is stated that the FE Protocol LFB is assigned the
Class id 0x2 while the FE Object LFB is assigned the Class id 0x1.

C2. Page 67 - Association Setup:
When the CE sends an association setup and within the setup message, the CE
requests the FE to send information in an unsolicited manner about some
attributes. Since the Association Setup Result contains only the answer, how
the FE sends back the requested attributes? It is considered a one-time
event (since it is a report type)? 

=============================
Questions:

Q1. About the Transactions, when does the FE keep state? When a commit is
received or when the FE has acknowledged that the operation can be executed?
If the second is true, then what happens after an abort message? Should it
be followed by a clear state message? 

Q2. Page 25 Figure 1. The Example is quite good for the All-or-none case.
What happens with the Execute-until-failure or Continue-Execute-on-failure?
It is the same? If the FE does not validate one request what happens? In the
EUF case does the CE send a Commit without sending any more commands?

Q3. Page 30 Figure 9. In the first heartbeat, the arrow is pointing in both
directions. What happens? Both FE and CE send HBs? Shoulnd't the CE send
first?

Q4. Properties (SET-PROP, GET-PROP)
What exactly is the definition of property? What is the diference between
the attribute and the property? The SET-PROPs are for events only?

=============================
XML Parsing:

I parsed the XML of the FEProtocol LFB with the latest Schema provided by
the latest model draft with the Altova XML Spy. It has two errors (of the
same kind).

In the capabilities section the:
access="read-only" 
cannot exist.