RE: MIB Doctor review: http://www.ietf.org/internet-drafts/draft-ietf-ipcdn-pktc-signaling-14.txt
"Romascanu, Dan (Dan)" <[email protected]> Mon, 6 Aug 2007 17:23:50 +0200
| Newsgroups | gmane.ietf.ipcdn |
|---|---|
| Message-ID | <EDC652A26FB23C4EB6384A4584434A042C85CD@307622ANEX5.global.avaya.com> |
Jean-Francois (as PROTO shepherd) and editors, There probably needs to be a revised version of the document, but this could until after the IETF LC, to see if we get any more comments. What path do you prefer - do a fast revision now and enter the IETF LC with a revised version, or proceed to IETF LC with the current version and consider Bert's comments as initial LC comments?=20 Dan =20 =20 > -----Original Message----- > From: Wijnen, Bert (Bert) [mailto:[email protected]]=20 > Sent: Monday, August 06, 2007 1:28 PM > To: Sumanth Channabasappa; [email protected];=20 > Satish Kumar at Texas Instruments; [email protected] > Cc: Jean-Francois Mule; Richard Woundy @ Comcast; Romascanu, Dan (Dan) > Subject: MIB Doctor review:=20 > http://www.ietf.org/internet-drafts/draft-ietf-ipcdn-pktc-sign > aling-14.txt >=20 > [bcc: to MIB doctors list] >=20 > Revision 14 has now been reviewed by me to see if my earlier=20 > comment during MIB doctor review of rev 13 have been addressed. >=20 > Here are my findings: >=20 > - basically this document is OK now. >=20 > - I still have a few things that I would prefer to get fixed: >=20 > 1.pktcSigPulseSignalTable OBJECT-TYPE > SYNTAX SEQUENCE OF PktcSigPulseSignalEntry > MAX-ACCESS not-accessible > STATUS current > DESCRIPTION > " The Pulse signal table defines the pulse signal operation. > There are nine types of international pulse signals, > with each signal having a set of provisionable parameters. > The values of the MIB objects in this table take effect > only if these parameters are not defined via signaling, in > which case the latter determines the values of the > parameters. This MIB table is required for the E line > package. >=20 > The "is required" is something that belongs in MODULE compliance and > NOT in the DESCRIPTION clause of an OBJECT-TYPE. I see that=20 > the objects > of this table have been included in the=20 > pktcELinePackageGroup and that > such is an conditionally optional GROUP on the MODULE-COMPLIANCE. SO > all that is needed is to remove the last sentence from the above > DESCRIPTION clause. >=20 > 2. pktcSigPulseSignalRepeatCount OBJECT-TYPE > SYNTAX Unsigned32 (1..50) > MAX-ACCESS read-write > STATUS current > DESCRIPTION > " This object specifies how many times to repeat a pulse. > This object is not used by the enableMeterPulse signal > type and as such must have a value of zero. The following > table defines the default values and the valid ranges for > this object depending on the signal type. >=20 > pktcSigPulseSignaltype Default Range >=20 > initialRing 1 1-5 > pulseLoopClose 1 1-50 > pulseLoopOpen 1 1-50 > enableMeterPulse (any value)(not used) > meterPulseBurst 1 1-50 > pulseNoBattery 1 1-50 > pulseNormalPolarity 1 1-50 > pulseReducedBattery 1 1-50 > pulseReversePolarity 1 1-50 >=20 >=20 > I am confused with the 2nd sentence of the DESCRIPTION clause. > I think the value zero is not valid (is it?) so better not=20 > speak of it. > The (any value) would be in the range 1..50 I think, but as stated, > it will not be used. So maybe, to avoid confusion, I would do: >=20 > DESCRIPTION > " This object specifies how many times to repeat a pulse. > This object is not used by the enableMeterPulse signal > type and in that case the value is irrelevant. The following > table defines the default values and the valid ranges for > this object depending on the signal type. >=20 > pktcSigPulseSignaltype Default Range >=20 > initialRing 1 1-5 > pulseLoopClose 1 1-50 > pulseLoopOpen 1 1-50 > enableMeterPulse (any value)(not used) >=20 > Maybe even also do > enableMeterPulse (1) (1-1, but not used) >=20 > - If a new revision is done, then I would appreciate if you can change > my affiliation from "Lucent Technologies" into "Alcatel-Lucent". > But no need to just do a new rev for that. >=20 > Below are some inline responses from me to things that I can=20 > live with but that I would personally (still) do different. I=20 > have removed/deleted all the comments that have been address=20 > and that I am happy with. >=20 > Bert Wijnen =20 >=20 > > -----Original Message----- > > From: Sumanth Channabasappa [mailto:[email protected]] > > Sent: Thursday, June 21, 2007 1:11 AM > > To: Wijnen, Bert (Bert); [email protected];=20 > Satish Kumar at=20 > > Texas Instruments; [email protected] > > Cc: Jean-Francois Mule; Richard Woundy @ Comcast;=20 > Romascanu, Dan (Dan) > > Subject: RE: MIB Doctor review:=20 > > http://www.ietf.org/internet-drafts/draft-ietf-ipcdn-pktc-sign > aling-13.txt > >=20 > > > Let me start to tell you that I am not a voice expert, so=20 > a lot of=20 > > > the actual content of this MIB module is abacadabra for me. I am=20 > > > assuming that other IPCDN WG members have evaluated (or will=20 > > > evaluate) the actual content w.r.t. the technical details and=20 > > > correctness. > > >=20 >=20 > The above still holds. >=20 > > > Let me also say that I find this MIB module pretty wieldy, > >=20 > > Thanks for the review and this opening comment. It is nice=20 > to hear and=20 > > the credit goes to all the ipcdn participants & implementers who=20 > > contributed to, and revised, the mib module over the years. > >=20 >=20 > When I say "wieldy", I mean that I see extensive/many=20 > objects, and my motto has always been: less objects is better. >=20 > > > - I wonder if the SYNTAX of SnmpAdminString makes sense for the > > > objects pktcSigCapabilityVersion and pktcSigCapabilityVendorExt. > > > It will work. But, SnmpAdminString is intended to contain human > > > readable (in any language/character set) strings. It seems that > the > > > values that you allow are very restricted and certainly cannot > > > be in any other language/character-set. > > > I personally can live with it... but you might want to > > > think of just an OCTET-STRING that you define exactly=20 > what it can > > > contain. > >=20 > > Can see your point; however, given the original intention to not be=20 > > restrictive regarding the values and to restrict this to human=20 > > readable strings only, we should probably let this be as-is. > >=20 >=20 > As I said, I can live with it, but I think I would use an OCTET STRING > or use my own TC for this specific semantic. >=20 > >=20 > > > - pktcSigPulseSignalTable DESCRIPTION clause speaks about the=20 > > > mandatory > > > nature of this table for E line package. This is=20 > MODULE-COMPLIANCE > > > stuff and should be expressed in the OBJECT-GROUP grouping and > > > MODULE-COMPLIANCE. > > >=20 > > > similar comment for pktcSigDevRingCadenceTable > > I propose we add another new object-group and make it=20 > > conditionally mandatory as you suggested earlier. > >=20 >=20 > So the above is the one that has not been fixed in the DESCRIPTION > clause > yet. >=20 > >=20 > > > - Have seen a SYNTAX of > > > SYNTAX INTEGER { > > > fsk(1), > > > dtmf(2) > > > } > > > for the signaling protocol multiple times. > > > Candidate for a TEXTUAL-CONVENTION? > >=20 > > Yes, a TC will be created. > >=20 >=20 > You did not do that. I can live with it though. >=20 > > > - For the read-create table, I wonder where the read-only objects > > > pktcNcsEndPntStatusCallIpAddressType and=20 > > > pktcNcsEndPntStatusCallIpAddress > > > come from? How does the agent determine those addresses.? > >=20 > > The DESCRIPTION needs to clarify this. To explain further,=20 > > the agent determines the CMS FQDN from the MIB Object=20 > > 'pktcNcsEndPntConfigCallAgentId'. It then uses DNS to resolve=20 > > the IP address. This resolution can lead to multiple IP=20 > > addresses and it picks one. It then populates=20 > > 'pktcNcsEndPntStatusCallIpAddress' with this IP address. > >=20 >=20 > So a DNS name in this object here is not valid. > And so a value of 'dns' for pktcNcsEndPntStatusCallIpAddressType > would not be valid either, right? That is not clear from the > SYNTAX. But since these are read-only objects I think it is OK. >=20 > > > Admin/Naming questions: > > >=20 > > > - The title speaks about: > > >=20 > > > Network-Based Call Signaling (NCS) MIB for PacketCable and > > >=20 > > > while the MIB Module is named: PKTC-IETF-SIG-MIB and > pktcIetfSigMib > > > Not that that is a bug... but it feels somewhat strange. > > >=20 > > > Later in the document, at various places the "NCS MIB"=20 > term comes=20 > > > back, and so people might expect to see IETF-NCS-MIB or=20 > ietfNcsMib > > > as names? > >=20 > > Let me check with the co-authors. I would leave it as-is, but=20 > > I think we need to clean up the text accordingly. > >=20 >=20 > I see some that cleanup. The title of the doc still has NCS. > But it is not a fatal flaw.. so it is up to you to decide if more > needs to be done about it. >=20 > >=20 > > >=20 > > > - Section 4 states: > > >=20 > > > Terminal Adapter (MTA) devices. The IETF NCS MIB module > (PKTC-IETF- > > > SIG-MIB) is intended to supersede various Signaling=20 > MIB modules=20 > > > from which it is partly derived: > > > - the PacketCable 1.0 Signaling MIB Specification > > > [PKT-SP-MIB-SIG-1.0], > > > - the PacketCable 1.5 Signaling MIB Specification > > > [PKT-SP-MIB-SIG-1.5], > > > - the ITU-T IPCablecom Signaling MIB requirements=20 > [ITU-T-J169], > > > - the ETSI Signaling MIB [ETSI-TS-101-909-9]. The ETSI > Signaling > > > MIB requirements also refer to various signal=20 > characteristics > > > defined in [ETSI-TS-101-909-4], [ETSI-EN-300-001], > > > [ETSI-EN-300-659-1], [ETSI-EN-300-324-1] and > [ETSI-TR-101-183]. > > >=20 > > > I know that many IPCDN WG members are all participating in > PackagetCable, > > > so I assume that superseding (is that same as obsoleting in IETF > terms?) > > > PacketCable documents is fine. But how about ITU-T and ETSI? Are > they > > > OK with the above statements? > >=20 > > Good point, unless we formally receive a liaison statement=20 > > about this, we should be more careful. Let's replace=20 > > "intended to supersede" with "intended to update" which gives=20 > > these 2 SDOs more room & control to do what they think is right. > >=20 >=20 > I am OK with the softened text. > Dan (your AD) may want to check this and see if he is OK with it. >=20 > > > - pktcNcsEndPntConfigTable and the objects in that table=20 > > > have a prefix of pktcNcs.... Why not pktcSigNcs.... ??? > > > Just to better avoid any future name clashes in other MIB=20 > > > modules . > >=20 > > I would be fine with this. > >=20 >=20 > But it has not been chganged. > I can live with it. It just would be better to make the change > so that there is more consistency in the naming and less risk for > any future clashes. >=20 >=20 > Bert >=20