Re: [IPFIX] WGLC for draft-ietf-ipfix-mib-variable-export-05

Hi Benoit, all,

See CM: for
more replies for the last review of draft-ietf-ipfix-mib-variable-export-05.


On 25/04/2014 14:34, Benoit Claise wrote:
> Dear all,
>
> Some feedback on the sections I already reviewed.
> Note that I agree with Juergen's feedback.
...
>> 1) The introduction contains details of the solution. I think it
>>     should instead contain the motivation and the architectural model
>>     currently in section 2. The new introduction should then be
>>     followed by a terminology section before an overview of the
>>     solution is provided (so that the terminology is defined). This is
>>     primarily text reorganization.
> The following text could be cut/pasted from the Introduction to a new section "High Level Solution Overview", somewhere after the terminology section:
>
>     This document specifies a method for creating IPFIX Option Templates
>     that are used to export the extra data required to describe MIB
>     variables (seeSection 4.1  <http://tools.ietf.org/html/draft-ietf-ipfix-mib-variable-export-05#section-4.1>).
>
>     This allows IPFIX Templates to contain any combination of fields
>     defined by traditional IPFIX Information Element(s) and/or MIB Object
>     Identifier(s).  The MIB Object Identifiers can reference either non-
>     indexed or indexed MIB object(s).  Enterprise-specific MIB Object
>     Identifiers are also supported.
>
>     This document also defines three standard Option Templates (see
>     Section 4.2  <http://tools.ietf.org/html/draft-ietf-ipfix-mib-variable-export-05#section-4.2>) that are used as part of the mechanism to export MIB
>     Object meta data:
>
>     o  mibFieldOption (Section 4.2.1  <http://tools.ietf.org/html/draft-ietf-ipfix-mib-variable-export-05#section-4.2.1>)
>
>     o  mibSubFieldOption (Section 4.2.2  <http://tools.ietf.org/html/draft-ietf-ipfix-mib-variable-export-05#section-4.2.2>)
>
>     o  mibTypeOption (Section 4.2.3  <http://tools.ietf.org/html/draft-ietf-ipfix-mib-variable-export-05#section-4.2.3>)
>
>     This document defines three classes of new IPFIX Information
>     Elements.  These are used to export values from the MIB, export
>     required Object Identifier information, and optionally export type
>     data from a MIB Module:
>
>     o  mibObjectValue Information Elements (Section 10.1  <http://tools.ietf.org/html/draft-ietf-ipfix-mib-variable-export-05#section-10.1>)
>
>     o  mibFieldOption Information Elements (Section 10.2  <http://tools.ietf.org/html/draft-ietf-ipfix-mib-variable-export-05#section-10.2>)
>
>     o  mibTypeInformation Information Elements (Section 10.3  <http://tools.ietf.org/html/draft-ietf-ipfix-mib-variable-export-05#section-10.3>)
>    
CM:

Agreed and implemented - the introduction is now a lot leaner and better.

>
>>
>> 2) I have trouble to understand the Figure "Architectural Overview".
>>     I think this should be removed. Figure 4 is more useful and it is
>>     at the right place in the document.
> Agreed.
CM:

Ok that figure has been removed.

>>
>> 3) I have terminology issues in several places. For example, RFC 2578
>>     uses the term 'columnar object' for what this document seems to
>>     call 'indexed object'. Why is it useful to call Flow Records Data
>>     Records? Using two terms for the same thing may just adds potential
>>     for confusion.
>  From RFC 7011:
>
>      +------------------+---------------------------------------------+
>      |                  |                 Contents                    |
>      |                  +--------------------+------------------------+
>      |       Set        |      Template      |         Record         |
>      +------------------+--------------------+------------------------+
>      |     Data Set     |          /         |     Data Record(s)     |
>      +------------------+--------------------+------------------------+
>      |   Template Set   | Template Record(s) |           /            |
>      +------------------+--------------------+------------------------+
>      | Options Template |  Options Template  |           /            |
>      |       Set        |      Record(s)     |                        |
>      +------------------+--------------------+------------------------+
>
>                      Figure A: Terminology Summary Table
>
> Section 3 provides:
>
>     This document prefers the more generic term "Data Record" (as opposed
>     to "Flow Record") in relation to the export of MIB objects.
>
> So flow record should be changed to data records throughout the doc.
CM: Done except for one mention in the above text you mentioned

     <t>
       This document prefers the more generic term "Data Record"
       (as opposed to "Flow Record") in relation to the export of MIB objects.
     </t>

Thanks,
colin

_______________________________________________
IPFIX mailing list
[email protected]
https://www.ietf.org/mailman/listinfo/ipfix