Re: [IPFIX] Review of draft-irtf-nmrg-location-ipfix-07.txt

--===============6477123730609862212==
Content-Type: multipart/signed;
 boundary="Apple-Mail=_964EAC82-E206-40BC-9525-51FD0BF1E506";
 protocol="application/pgp-signature"; micalg=pgp-sha512


--Apple-Mail=_964EAC82-E206-40BC-9525-51FD0BF1E506
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

Hello,
We haven=E2=80=99t really get a "proper review" of the document by IPFIX =
experts. Recently, we had a discussion with IANA and they asked =
IE-doctors to make a review, since that we received some points to be =
fixed regarding the proposed IE. I can forward to you the other comments =
from IE-doctors that we have received by IANA.

Thank you for your comments, Ok we will fix the raised issues in the =
document.
Best regards.


> On 03 Mar 2017, at 11:42, PJ Aitken <[email protected]> wrote:
>=20
> Authors, has this document been reviewed by any IPFIX experts?
>=20
> I see a request on November 23rd, but no reviews. So let me sign up =
for that.
>=20
>=20
> First, I took a quick look at the Figures in Appendix B:
>=20
> Figure 1: the Field Count should be 5, not 2.
>=20
> Figure 2: the size of the optional Padding field is wrong: the figure =
shows 9 bits rather than 8.
>=20
> Figure 4: the Length of 32 should be 28. The =
"geospatialLocationPosLat" Information Element isn't defined.
>=20
> Figure 5: the Field Count of 2 should be 3.
>=20
> Figure 7: The "geospatialLocationPostLng" and "geospatialLocationtLng" =
Information Elements aren't defined.
>=20
> Figure 9: The sizes of the "CivicValue" data fields are not shown =
correctly. eg, "Inria Nancy-Grand Est" is depicted in 6 octets when it =
should contain 21. Therefore the Figure is misleading and difficult to =
understand; it is not a good example. Please redraw the figure =
correctly. Please mark the variable-lengths eg "vlen =3D 21".
>=20
> Figure 11:
>    The Set IDs (311, 312, 313) do not correspond to the Template IDs =
in Figure 10 (306, 307, 308).
>    Again, the "Inria Nancy-Grand Grand Est" field is depicted in 6 =
octets rather than the requisite 27. Without the repeated "Grand", the =
21 would be correct. Please write "vlen=3D21"
>    The "Civic location Attr length" of 25 seems wrong.
>=20
>=20
> This document is not ready for publication. Please post an updated =
version so I can check that all the IPFIX details are correct.
>=20
> Thanks,
> P.


--Apple-Mail=_964EAC82-E206-40BC-9525-51FD0BF1E506
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org

iQIcBAEBCgAGBQJYuU0nAAoJEBX1Mi7AAzI69l8P/0586ZzqVhUAhRWi/pi7vg+8
QwMfuKFN94iGa2lPBxxGO4UHdMOPiTcO6v4+cc7tu4PL1nqNOXmoeLWFoBSnL/uE
bTvjSg7E3hI1n0SkO7axyMVDtK19L80vzPBVMOdj8nrR1mtXjZ3s0FGV+8Y6XEHR
4Ncft/Hg1fCNlS/RV1+BpIz2Y2mKF4KfyFeAR9OWnZYVsrrguekpObONgCXyreC5
dWpZ25x8Gy5Fst2+M76p6iiMiD0QOe3JjujRGtRrdg5ZquMxIydx/TMPDBQKdhHP
9f1iqCHECxEPhF5ZyCKNJgj5R+73JBgmoMnjmWASm/W2l5HXOfjREwmdrzmZRzqO
gMUMiT6Y9I4My6XubUmv1OVE2TWTPiW5ABMXJ9S1XmnWZJD9pRIsYd4szSt3eiOU
VwPMmG1MZIfGcfQgugSbimuOuL/euJRPy9pvE1PqonGFh4pWFyGEgkwPy3orSLjl
mzjOrg4GvcAbKWOC42MvdHESC4dv7CCOl/ojaof9IsPShICqJXNd6tStO2iaa8hG
hN1ub9T6MR122Lq2Oa9+k+c24loTrKeFXFz3j9up4Fo5BxOtJU1KjCv0rkJtH1Iy
d43IGEqpYPhpuBcWA2U12nNFNtietMgveopQzVQzIB7Bt+tf13XEPZTT1rHqIIuD
uYh3fVLDoyUsm8Z4gR/6
=NRzx
-----END PGP SIGNATURE-----

--Apple-Mail=_964EAC82-E206-40BC-9525-51FD0BF1E506--


--===============6477123730609862212==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
IPFIX mailing list
[email protected]
https://www.ietf.org/mailman/listinfo/ipfix

--===============6477123730609862212==--