NITs comments on draft-ietf-ipoib-ibmib-tc-mib-03.txt
"Randy Presuhn" <[email protected]>
| Newsgroups | gmane.ietf.ipoib |
|---|---|
| Message-ID | <000a01c38c62$a1ada020$7f1afea9@oemcomputer> |
Hi - Here are my ID-nits comments on draft-ietf-ipoib-tv-mib-03.txt: Ultra-trivial formatting: trailing blanks make line 88 too long (73 characters) trailing blanks make line 302 too long (76 characters) "." at the end of a sentence is sometimes followed by a single space, sometimes by two. Should be two consistently. Strongly recommend fixing these before going to RFC editor; any reformatting of DESCRIPTION texts is best done by a document's author. Serious: Byte-order diagram for IpIpoibClientIdentifier doesn't use network byte order. Please take a look at draft-rfc-editor-rfc2223bis-07.txt section 3.4 for more details. Minor: RFC 2119 is referenced normatively, but is missing from the list of normative references. Acronyms should be expanded on first use. Ones that jumped out at me were: IBA LID (though embedded in DLID) IEEE HCA TCA Missing "." after the abbreviation "Vol." The order of sections should be aligned with draft-rfc-editor-rfc2223bis-07.txt section 4, i.e, mib definitions (stays in current location) acknowledgements (currently 9) security considerations (currently 8) Normative references (currently 6) Informative references (currently 7) Author's address (stays in current locations) (My *personal* preference is to make the normative and informative references sections sub-sections of a single references section, but AFAIK that is merely a personal preference.) Author's address has no country. Randy