[manet] Re: Opsdir early review of draft-ietf-manet-dlep-tra ffic-classification-12

Hi Carlos & Tina



I have taken editorship of this document to help address the comments and move it along. We have conferred with the other authors on these points.



We have addressed the issue raised by you and other commenters.

Specific Comments inline [Don]



Thank you for your comments.

Don



-----Original Message-----

From: Carlos Pignataro via Datatracker <[email protected]<mailto:[email protected]>>

Sent: Tuesday, July 30, 2024 5:55 PM

To: [email protected]<mailto:[email protected]>

Cc: [email protected]<mailto:[email protected]>; [email protected]<mailto:[email protected]>

Subject: Opsdir early review of draft-ietf-manet-dlep-traffic-classification-12



Reviewer: Tina Tsou

Review result: Has Issues



1. Introduction: The purpose and scope are well-defined. Consider providing additional real-world examples to illustrate the need for traffic classification.



[Don] We have added a diagram and a sequence diagram to help explain the Credit Flow Control and the Traffic Classification in the https://datatracker.ietf.org/doc/draft-ietf-manet-dlep-credit-flow-control/.  As I explained to another reviewer this draft is just about the traffic classification data types.  The Credit flow control draft describe s the overall operation.  This draft is separated from the credit flow control to allow for other future extensions.



2. Traffic Classification Types: The classification types are comprehensive.

Ensure that the definitions are aligned with industry standards.

[Don] OK.



3. Traffic Classification Attributes: The attributes are detailed and well-explained. Verify that the attribute values cover all potential use cases.

[Don] OK.





4. Traffic Classification Procedures: The procedures are clear and logically structured. Consider adding flowcharts or diagrams to visualize the message exchanges.

[Don] We have added a diagram and a sequence diagram   Credit flow control draft.



5. IANA Considerations: The section is thorough. Double-check the parameter values and ensure all necessary registrations are included.



6. Security Considerations: The security section addresses key risks. Consider expanding on specific attack scenarios and their mitigations.

[Don] We aligned the security sections of the two drafts.



By addressing these feedback areas, the document can be improved for clarity, completeness, and technical accuracy.

_______________________________________________
manet mailing list -- [email protected]
To unsubscribe send an email to [email protected]