[manet] Review of draft-ietf-manet-dlep-radio-band-01
Donald Eastlake <[email protected]>
| Newsgroups | gmane.ietf.manet |
|---|---|
| Message-ID | <CAF4+nEG+xN=Fahywwff1BpLaWQWuJAx=WitwCGrgeB2KnQqbsA@mail.gmail.com> |
Issues ------ Figure 1 is confusing. Assuming that Carrier Frequency and Bandwidth are 64-bit quantities, the 32-bit boxes in the Figure should not have duplicate names. Assuming network byte order, the first should, in each case, have ", Upper Half" appended to the name in the box and the second should have ", Lower Half" appended or a similar change made. For the text after Figure 1, please reconcile the difference between "Carrier Frequency" in the Figure and "Center Frequence" in the text. The text needs to say that the frequency and bandwidth items are 64 bits, assuming that's true. Assuming these 64-bit fields are unsigned, the draft should say so to avoid ambiguity. Nits ---- Section 1.:, Requirements language boilerplate is out of date and must be updated. See RFC 8174. Section 3, first sentence: "contains information which radio" -> "contains information about which radio" or "contains information on which radio" Thanks, Donald =============================== Donald E. Eastlake 3rd +1-508-333-2270 (cell) 2386 Panoramic Circle, Apopka, FL 32703 USA [email protected] _______________________________________________ manet mailing list -- [email protected] To unsubscribe send an email to [email protected]