[manet] Re: Gunter Van de Velde's No Objection on draft-ie tf-manet-dlep-credit-flow-control-17: (with COMMENT)
Donald Eastlake <[email protected]>
| Newsgroups | gmane.ietf.manet |
|---|---|
| Message-ID | <CAF4+nEEkuBMo_u8ZEpJRgHP6dkWSswQaVxmhvvsDmWb8V73pxA@mail.gmail.com> |
Hi Gunter, On Thu, Feb 6, 2025 at 7:28 AM Gunter Van de Velde via Datatracker <[email protected]> wrote: > > Gunter Van de Velde has entered the following ballot position for > draft-ietf-manet-dlep-credit-flow-control-17: No Objection > > ... > > ---------------------------------------------------------------------- > COMMENT: > ---------------------------------------------------------------------- > > # Gunter Van de Velde, RTG AD, comments for > draft-ietf-manet-dlep-credit-flow-control-17 > > # The line numbers used are rendered from IETF idnits tool: > https://author-tools.ietf.org/api/idnits?url=https://www.ietf.org/archive/id/draft-ietf-manet-dlep-credit-flow-control-17.txt > > # Many thanks to Dhruv Dhody for the RTGDIR review, and the follow up. > > # Detailed Review > # =============== > > 400 Length: > 401 16 > 402 > 403 Per [RFC8175] Length is the number of octets in the Data Item. It > 404 MUST be equal to sixteen (16). > > GV> This field seems slightly underspecified. Maybe point out that the Length > is set in multiples of bytes, not bits. GV> What must happen if the length is > not set to value '16'? ignore? send a trap? reset the process? Please advice The description says "number of octets" which seems to already say that it is in bytes, not bits. If the length is a value other than 16, then the Data Item is corrupt and the message including that Data Item is ignored. Wording to this effect has been added in version -18. > 496 Length: > 497 2 > 498 > 499 Per [RFC8175] Length is the number of octets in the Data Item. It > 500 MUST be equal to two (2). > > GV> similar observation as above. Similar response. And similar parallel changes have been made elsewhere in the draft. Thanks, Donald =============================== Donald E. Eastlake 3rd +1-508-333-2270 (cell) 2386 Panoramic Circle, Apopka, FL 32703 USA [email protected] > Kind Regards, > Gunter Van de Velde > Routing Area Director _______________________________________________ manet mailing list -- [email protected] To unsubscribe send an email to [email protected]