RE: Packet format in ENRP
Silverton Aron-C1710C <[email protected]>
| Newsgroups | gmane.ietf.rserpool |
|---|---|
| Message-ID | <FD52892BD296D71183B400065BFCB6900C2F5163@il02exm12> |
Michael, The rest of here at Motorola discussed your comments this morning and we, too, agree on all accounts. Do we need to wait for further agreement, or should we proceed with updating our documentation and implementations? Regards, Aron Qiaobing Xie <> wrote: > Michael, > > Michael Tuexen wrote: > >> Dear all, >> >> while writing the ethereal dissector for ENRP I found some things I >> would like to change: >> >> Section 3.1 >> >> The length field is shown as 'Message Length = 0xC' which >> is not correct because there can be some parameters. > > good catch. > >> >> Section 3.3 >> >> Could we exchange the R and M bit? This would align the >> R bit position with the reject bit in a PEER_LIST_RESONSE message. > > I agree. Better alignment is always good :-) > >> >> Section 3.4 >> >> To have a similar layout of the packets i would suggest to change it >> to: >> >> 0 1 2 3 >> 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 >> 0 1 >> >> >> >> >> >> >> >> >> >> >> >> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | >> Type = 0x4 |0|0|0|0|0|0|0|0| Message Length | >> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | >> Sender Server's ID | >> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | >> Receiver Server's ID | >> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | >> Update Action | (reserved) | >> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ : >> Pool handle : >> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ : >> Pool Element : >> >> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ > > Makes sense to me. I agree. > > regards, > -Qiaobing > >> >> Best regards >> Michael >> >> PS.: ethereal version 0.10.5 will support both ASAP and ENRP... >> >> >> _______________________________________________ >> rserpool mailing list >> [email protected] https://www1.ietf.org/mailman/listinfo/rserpool >> > > > _______________________________________________ > rserpool mailing list > [email protected] https://www1.ietf.org/mailman/listinfo/rserpool