Re: Last Call: draft-ietf-rserpool-mib (Reliable ServerPooling: Management Information Base using SMIv2) toExperimental RFC)
"Bert Wijnen \(IETF\)" <[email protected]> Thu, 5 Feb 2009 11:46:08 +0100
| Newsgroups | gmane.ietf.rserpool |
|---|---|
| Organization | Consultant |
| Message-ID | <FE4F35AAE4964BF88D9F75EEAC7927A4@BertLaptop> |
This is a multi-part message in MIME format.
--===============1299426119==
Content-Type: multipart/alternative;
boundary="----=_NextPart_000_0C7A_01C98787.55C5F060"
This is a multi-part message in MIME format.
------=_NextPart_000_0C7A_01C98787.55C5F060
Content-Type: text/plain;
charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable
Thanks Thomas for the quick turn-arounds. This helps a lot with =
context-switching.
In other words, this way I can quickly re-check (as opposed to some MIB =
reviews=20
I have done where it takes montsh for a new revision to show up).
The SMICng check show two naming issues left:
C:\bw\smicng\work>smicng rserpool.inc
W: f(rserpool.mi2), (761,1) Sequence "RserpoolPoolElementEntry" and =
Row "rserpoolPEEntry" should have related names
W: f(rserpool.mi2), (1074,1) Sequence "RserpoolPoolUserEntry" and Row =
"rserpoolPUEntry" should have related names
*** 0 errors and 2 warnings in parsing
Further, you claim:
> The normal setup (according to rfc4181) would be something like:
>
> rserpoolMIBObjects OBJECT-IDENTIFIER ::=3D { rserpoolMIB 1 }
> rserpoolMIBConformance OBJECT IDENTIFIER ::=3D { rserpoolMIB 2 }
>
> rserpoolENRPServers OBJECT IDENTIFIER ::=3D { rserpoolMIBObjects =
1 }
> rserpoolPoolElements OBJECT IDENTIFIER ::=3D { rserpoolMIBObjects =
2 }
> rserpoolPoolUsers OBJECT IDENTIFIER ::=3D { =
rserpoolMIBObjects 3 }
>
> Your new MIB module has no indertation at all.
> Not a fatal flaw, but does not help in readability.
Fixed.
But I do nto see that fix, do I ??
Bert
----- Original Message -----=20
From: Thomas Dreibholz=20
To: Bert Wijnen (IETF)=20
Cc: [email protected] ; MIB Doctors (E-mail) ; David B Harrington=20
Sent: Thursday, February 05, 2009 7:29 AM
Subject: Re: [Rserpool] Last Call: draft-ietf-rserpool-mib (Reliable =
ServerPooling: Management Information Base using SMIv2) toExperimental =
RFC)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Dear all,
attached to this mail you find the updated version of the RSerPool MIB =
module.
See my comments inline.
> >> - According to RFC4181 this one
> >> rserpoolMIBConformance OBJECT IDENTIFIER ::=3D { =
rserpoolMIB 4 }
> >> should change to
> >> rserpoolMIBConformance OBJECT IDENTIFIER ::=3D { =
rserpoolMIB 2
> >> }
> >
> > 1 is used for the ENRP servers branch, 2 is used for PE branch, 3 =
for PU
> > branch. The next available number is 4.
Fixed.
> The normal setup (according to rfc41`81) would be something like:
>
> rserpoolMIBObjects OBJECT-IDENTIFIER ::=3D { rserpoolMIB 1 =
}
> rserpoolMIBConformance OBJECT IDENTIFIER ::=3D { rserpoolMIB 2 }
>
> rserpoolENRPServers OBJECT IDENTIFIER ::=3D { =
rserpoolMIBObjects 1 }
> rserpoolPoolElements OBJECT IDENTIFIER ::=3D { =
rserpoolMIBObjects 2 }
> rserpoolPoolUsers OBJECT IDENTIFIER ::=3D { =
rserpoolMIBObjects 3 }
>
> Your new MIB module has no indertation at all.
> Not a fatal flaw, but does not help in readability.
Fixed.
> The new MIB module causes these SMICng warnings:
> W: f(rserpool.mi2), (137,1) Sequence "RSerPoolENRPEntry" and Row
> "rserpoolENRPEntry" should have related names W: f(rserpool.mi2), =
(276,1)
> Sequence "RSerPoolENRPPoolEntry" and Row "rserpoolENRPPoolEntry" =
should
> have related names W: f(rserpool.mi2), (315,1) Sequence
> "RSerPoolENRPPoolElementEntry" and Row =
"rserpoolENRPPoolElementEntry"
> should have related names W: f(rserpool.mi2), (465,1) Sequence
> "RSerPoolENRPASAPAddrTableEntry" and Row =
"rserpoolENRPASAPAddrTableEntry"
> should have related names W: f(rserpool.mi2), (520,1) Sequence
> "RSerPoolENRPUserAddrTableEntry" and Row =
"rserpoolENRPUserAddrTableEntry"
> should have related names W: f(rserpool.mi2), (584,1) Sequence
> "RSerPoolENRPENRPAddrTableEntry" and Row =
"rserpoolENRPENRPAddrTableEntry"
> should have related names W: f(rserpool.mi2), (636,1) Sequence
> "RSerPoolENRPPeerEntry" and Row "rserpoolENRPPeerEntry" should have =
related
> names W: f(rserpool.mi2), (695,1) Sequence =
"RSerPoolENRPPeerAddrTableEntry"
> and Row "rserpoolENRPPeerAddrTableEntry" should have related names =
W:
> f(rserpool.mi2), (753,1) Sequence "RSerPoolPoolElementEntry" and Row
> "rserpoolPEEntry" should have related names W: f(rserpool.mi2), =
(941,1)
> Sequence "RSerPoolPEASAPAddrTableEntry" and Row
> "rserpoolPEASAPAddrTableEntry" should have related names W:
> f(rserpool.mi2), (994,1) Sequence "RSerPoolPEUserAddrTableEntry" and =
Row
> "rserpoolPEUserAddrTableEntry" should have related names W:
> f(rserpool.mi2), (1060,1) Sequence "RSerPoolPoolUserEntry" and Row
> "rserpoolPUEntry" should have related names
>
> *** 0 errors and 12 warnings in parsing
>
> Probably cause by sticking to a better naming convention. Bit it =
would be
> consistent throughout. It seems likd what you have is not absolutely
> incorrect. Yet... it is certainly not following the way things are =
normally
> done.
>
> I think this is more what I would expect:
>
> rserpoolENRPTable OBJECT-TYPE
> SYNTAX SEQUENCE OF RserpoolENRPEntry
>
> Then the ENTRY spec should read like:
>
> rserpoolENRPEntry OBJECT-TYPE
> SYNTAX RserpoolENRPEntry
>
> And then:
>
> RserpoolENRPEntry ::=3D SEQUENCE {
> rserpoolENRPIndex Unsigned32,
>
>
> Same further down in the MIB module.
I replaced the prefix RSerPool by Rserpool. The warning should be =
fixed now.=20
Bert, please could you run the SMICng program again on the updated MIB =
module?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkmKh3IACgkQ32BbsHYPLWVI/wCffN6IE/gABUiaqRHRCaXrcm74
ZqAAn3ETcUhzC8nPrhoMJ8QeKZ2Iv/CT
=3D1J4Z
-----END PGP SIGNATURE-----
------=_NextPart_000_0C7A_01C98787.55C5F060
Content-Type: text/html;
charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META http-equiv=3DContent-Type content=3D"text/html; =
charset=3Diso-8859-15">
<META content=3D"MSHTML 6.00.6001.18183" name=3DGENERATOR>
<STYLE></STYLE>
</HEAD>
<BODY bgColor=3D#ffffff>
<DIV><FONT size=3D2>Thanks Thomas for the quick turn-arounds. This helps =
a lot=20
with context-switching.</FONT></DIV>
<DIV><FONT size=3D2>In other words, this way I can quickly re-check (as =
opposed to=20
some MIB reviews </FONT></DIV>
<DIV><FONT size=3D2>I have done where it takes montsh for a new revision =
to show=20
up).</FONT></DIV>
<DIV><FONT size=3D2></FONT> </DIV>
<DIV><FONT size=3D2>The SMICng check show two naming issues=20
left:</FONT></DIV>
<DIV><FONT size=3D2></FONT> </DIV>
<DIV><FONT size=3D2> C:\bw\smicng\work>smicng =
rserpool.inc<BR> W:=20
f(rserpool.mi2), (761,1) Sequence "RserpoolPoolElementEntry" and Row=20
"rserpoolPEEntry" should have related names<BR> W: =
f(rserpool.mi2),=20
(1074,1) Sequence "RserpoolPoolUserEntry" and Row "rserpoolPUEntry" =
should have=20
related names</FONT></DIV>
<DIV><FONT size=3D2></FONT> </DIV>
<DIV><FONT size=3D2> *** 0 errors and 2 warnings in =
parsing</FONT></DIV>
<DIV><FONT size=3D2></FONT> </DIV>
<DIV><FONT size=3D2>Further, you claim:</FONT></DIV>
<DIV>> The normal setup (according to rfc4181) would be something=20
like:<BR>><BR>>=20
rserpoolMIBObjects =
OBJECT-IDENTIFIER ::=3D { rserpoolMIB 1 }<BR>> =
rserpoolMIBConformance =20
OBJECT IDENTIFIER ::=3D { rserpoolMIB 2 }<BR>><BR>>=20
rserpoolENRPServers OBJECT =
IDENTIFIER ::=3D {=20
rserpoolMIBObjects 1 }<BR>>=20
rserpoolPoolElements OBJECT IDENTIFIER =
::=3D {=20
rserpoolMIBObjects 2 }<BR>>=20
rserpoolPoolUsers &n=
bsp;=20
OBJECT IDENTIFIER ::=3D { rserpoolMIBObjects 3 }<BR>><BR>> Your =
new MIB=20
module has no indertation at all.<BR>> Not a fatal flaw, but does not =
help in=20
readability.<BR><BR>Fixed.<BR></DIV>
<DIV><FONT size=3D2></FONT> </DIV>
<DIV><FONT size=3D2>But I do nto see that fix, do I ??</FONT></DIV>
<DIV><FONT size=3D2></FONT> </DIV>
<DIV><FONT size=3D2>Bert</FONT></DIV>
<DIV><FONT size=3D2></FONT> </DIV>
<BLOCKQUOTE=20
style=3D"PADDING-RIGHT: 0px; PADDING-LEFT: 5px; MARGIN-LEFT: 5px; =
BORDER-LEFT: #000000 2px solid; MARGIN-RIGHT: 0px">
<DIV style=3D"FONT: 10pt arial">----- Original Message ----- </DIV>
<DIV=20
style=3D"BACKGROUND: #e4e4e4; FONT: 10pt arial; font-color: =
black"><B>From:</B>=20
<A [email protected] =
href=3D"mailto:[email protected]">Thomas=20
Dreibholz</A> </DIV>
<DIV style=3D"FONT: 10pt arial"><B>To:</B> <A =
[email protected]=20
href=3D"mailto:[email protected]">Bert Wijnen (IETF)</A> </DIV>
<DIV style=3D"FONT: 10pt arial"><B>Cc:</B> <A =
[email protected]=20
href=3D"mailto:[email protected]">[email protected]</A> ; <A=20
[email protected] href=3D"mailto:[email protected]">MIB =
Doctors=20
(E-mail)</A> ; <A [email protected]=20
href=3D"mailto:[email protected]">David B Harrington</A> </DIV>
<DIV style=3D"FONT: 10pt arial"><B>Sent:</B> Thursday, February 05, =
2009 7:29=20
AM</DIV>
<DIV style=3D"FONT: 10pt arial"><B>Subject:</B> Re: [Rserpool] Last =
Call:=20
draft-ietf-rserpool-mib (Reliable ServerPooling: Management =
Information Base=20
using SMIv2) toExperimental RFC)</DIV>
<DIV><BR></DIV>-----BEGIN PGP SIGNED MESSAGE-----<BR>Hash: =
SHA1<BR><BR>Dear=20
all,<BR><BR>attached to this mail you find the updated version of the =
RSerPool=20
MIB module.<BR><BR>See my comments inline.<BR><BR><BR>> >> -=20
According to RFC4181 this one<BR>>=20
>> =20
rserpoolMIBConformance OBJECT IDENTIFIER ::=3D { rserpoolMIB 4 =
}<BR>>=20
>> should change to<BR>>=20
=
>>  =
; =20
rserpoolMIBConformance OBJECT IDENTIFIER ::=3D { rserpoolMIB 2<BR>> =
>>=20
}<BR>> ><BR>> > 1 is used for the ENRP servers branch, 2 =
is used=20
for PE branch, 3 for PU<BR>> > branch. The next available number =
is=20
4.<BR><BR>Fixed.<BR><BR><BR>> The normal setup (according to =
rfc41`81)=20
would be something like:<BR>><BR>>=20
=
rserpoolMIBObjects =
OBJECT-IDENTIFIER ::=3D { rserpoolMIB 1 }<BR>> =
rserpoolMIBConformance =20
OBJECT IDENTIFIER ::=3D { rserpoolMIB 2 }<BR>><BR>>=20
rserpoolENRPServers OBJECT =
IDENTIFIER ::=3D=20
{ rserpoolMIBObjects 1 }<BR>>=20
rserpoolPoolElements OBJECT IDENTIFIER =
::=3D {=20
rserpoolMIBObjects 2 }<BR>>=20
=
rserpoolPoolUsers &n=
bsp;=20
OBJECT IDENTIFIER ::=3D { rserpoolMIBObjects 3 }<BR>><BR>> Your =
new MIB=20
module has no indertation at all.<BR>> Not a fatal flaw, but does =
not help=20
in readability.<BR><BR>Fixed.<BR><BR><BR>> The new MIB module =
causes these=20
SMICng warnings:<BR>> W: f(rserpool.mi2), (137,1) Sequence=20
"RSerPoolENRPEntry" and Row<BR>> "rserpoolENRPEntry" should have =
related=20
names W: f(rserpool.mi2), (276,1)<BR>> Sequence =
"RSerPoolENRPPoolEntry" and=20
Row "rserpoolENRPPoolEntry" should<BR>> have related names W:=20
f(rserpool.mi2), (315,1) Sequence<BR>> =
"RSerPoolENRPPoolElementEntry" and=20
Row "rserpoolENRPPoolElementEntry"<BR>> should have related names =
W:=20
f(rserpool.mi2), (465,1) Sequence<BR>> =
"RSerPoolENRPASAPAddrTableEntry" and=20
Row "rserpoolENRPASAPAddrTableEntry"<BR>> should have related names =
W:=20
f(rserpool.mi2), (520,1) Sequence<BR>> =
"RSerPoolENRPUserAddrTableEntry" and=20
Row "rserpoolENRPUserAddrTableEntry"<BR>> should have related names =
W:=20
f(rserpool.mi2), (584,1) Sequence<BR>> =
"RSerPoolENRPENRPAddrTableEntry" and=20
Row "rserpoolENRPENRPAddrTableEntry"<BR>> should have related names =
W:=20
f(rserpool.mi2), (636,1) Sequence<BR>> "RSerPoolENRPPeerEntry" and =
Row=20
"rserpoolENRPPeerEntry" should have related<BR>> names W: =
f(rserpool.mi2),=20
(695,1) Sequence "RSerPoolENRPPeerAddrTableEntry"<BR>> and Row=20
"rserpoolENRPPeerAddrTableEntry" should have related names W:<BR>>=20
f(rserpool.mi2), (753,1) Sequence "RSerPoolPoolElementEntry" and =
Row<BR>>=20
"rserpoolPEEntry" should have related names W: f(rserpool.mi2),=20
(941,1)<BR>> Sequence "RSerPoolPEASAPAddrTableEntry" and =
Row<BR>>=20
"rserpoolPEASAPAddrTableEntry" should have related names W:<BR>>=20
f(rserpool.mi2), (994,1) Sequence "RSerPoolPEUserAddrTableEntry" and=20
Row<BR>> "rserpoolPEUserAddrTableEntry" should have related names=20
W:<BR>> f(rserpool.mi2), (1060,1) Sequence "RSerPoolPoolUserEntry" =
and=20
Row<BR>> "rserpoolPUEntry" should have related =
names<BR>><BR>> *** 0=20
errors and 12 warnings in parsing<BR>><BR>> Probably cause by =
sticking=20
to a better naming convention. Bit it would be<BR>> consistent =
throughout.=20
It seems likd what you have is not absolutely<BR>> incorrect. =
Yet... it is=20
certainly not following the way things are normally<BR>>=20
done.<BR>><BR>> I think this is more what I would=20
expect:<BR>><BR>> rserpoolENRPTable=20
OBJECT-TYPE<BR>> SYNTAX =
SEQUENCE=20
OF RserpoolENRPEntry<BR>><BR>> Then the ENTRY spec should read=20
like:<BR>><BR>> rserpoolENRPEntry=20
OBJECT-TYPE<BR>> SYNTAX =20
RserpoolENRPEntry<BR>><BR>> And =
then:<BR>><BR>> =20
RserpoolENRPEntry ::=3D SEQUENCE {<BR>> =20
=
rserpoolENRPIndex &n=
bsp; =20
Unsigned32,<BR>><BR>><BR>> Same further down in the MIB=20
module.<BR><BR>I replaced the prefix RSerPool by Rserpool. The warning =
should=20
be fixed now. <BR>Bert, please could you run the SMICng program again =
on the=20
updated MIB module?<BR><BR>-----BEGIN PGP SIGNATURE-----<BR>Version: =
GnuPG=20
v1.4.9=20
=
(GNU/Linux)<BR><BR>iEYEARECAAYFAkmKh3IACgkQ32BbsHYPLWVI/wCffN6IE/gABUiaqR=
HRCaXrcm74<BR>ZqAAn3ETcUhzC8nPrhoMJ8QeKZ2Iv/CT<BR>=3D1J4Z<BR>-----END=20
PGP SIGNATURE-----<BR></BLOCKQUOTE></BODY></HTML>
------=_NextPart_000_0C7A_01C98787.55C5F060--
--===============1299426119==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
rserpool mailing list
[email protected]
https://www.ietf.org/mailman/listinfo/rserpool
--===============1299426119==--