RE: SFL Memory Leaks
"Horvath, Tom" <[email protected]> Fri, 29 Apr 2005 14:17:25 -0400
| Newsgroups | gmane.ietf.sfl |
|---|---|
| Message-ID | <[email protected]> |
This is a multi-part message in MIME format. ------_=_NextPart_001_01C54CE7.B1C7CA0E Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Michel, =20 Good catch. I verified that both are indeed memory leaks and that your modifications were appropriate. We will include these modifications in the next SFL patch or release. =20 Thanks, =20 Tom Horvath Principal Security Systems Engineer _______________________________ BAE SYSTEMS Information Technology 141 National Business Pkwy. Suite 210 Annapolis Junction, MD 20701 [email protected] (301) 939-2728 _____ =20 From: Michel Kinasz [mailto:[email protected]]=20 Sent: Tuesday, April 26, 2005 4:53 PM To: Horvath, Tom Subject: SFL Memory Leaks=20 =20 Hello Tom,=20 I am using SFL 2.5 with visual studio 6.0.=20 I had to modify SFL sources to fix some memory leaks:=20 sm_SignBuf.cpp Line 226:=20 Changed=20 if (*pTmpAlg =3D=3D oidDigestEncryption)=20 {=20 break;=20 }=20 To=20 if (*pTmpAlg =3D=3D oidDigestEncryption)=20 {=20 break;=20 }=20 else=20 {=20 free(pTmpAlg);=20 pTmpAlg =3D NULL;=20 }=20 =20 sm_free3_RSA.cpp Line 2123=20 Added=20 if (NULL !=3D pszPasswordMAC)=20 {=20 free(pszPasswordMAC);=20 pszPasswordMAC =3D NULL;=20 }=20 Could you confirm that these modifications are valid?=20 Thanks,=20 Michel Kinasz=20 ImageWare Systems Inc.=20 =20 The information contained in this transmission contains potentially privileged, export controlled and/or confidential information of Imageware Systems, Inc. or its customers or partners. It is intended only to be read by the person(s) named above and for no other purpose. You are hereby notified that any dissemination, distribution, duplication of this communication or use of its contents for any purpose not authorized expressly by Imageware Systems, Inc. is strictly prohibited and could lead to both civil and/or criminal penalties. If you are not the intended recipient, you are prohibited to review the contents herein and please contact the sender by reply e-mail and destroy all copies of the original message. To reply to our e-mail administrator directly, please send an e-mail to [email protected] ------_=_NextPart_001_01C54CE7.B1C7CA0E Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable <html> <head> <meta http-equiv=3DContent-Type content=3D"text/html; = charset=3Dus-ascii"> <meta name=3DGenerator content=3D"Microsoft Word 11 (filtered)"> <title>SFL Memory Leaks </title> <style> <!-- /* Font Definitions */ @font-face {font-family:Tahoma; panose-1:2 11 6 4 3 5 4 4 2 4;} /* Style Definitions */ p.MsoNormal, li.MsoNormal, div.MsoNormal {margin:0in; margin-bottom:.0001pt; font-size:12.0pt; font-family:"Times New Roman";} a:link, span.MsoHyperlink {color:blue; text-decoration:underline;} a:visited, span.MsoHyperlinkFollowed {color:purple; text-decoration:underline;} p {margin-right:0in; margin-left:0in; font-size:12.0pt; font-family:"Times New Roman";} span.EmailStyle18 {font-family:Arial; color:navy;} @page Section1 {size:8.5in 11.0in; margin:1.0in 1.25in 1.0in 1.25in;} div.Section1 {page:Section1;} --> </style> </head> <body lang=3DEN-US link=3Dblue vlink=3Dpurple> <div class=3DSection1> <p class=3DMsoNormal><font size=3D2 color=3Dnavy face=3DArial><span = style=3D'font-size: 10.0pt;font-family:Arial;color:navy'>Michel,</span></font></p> <p class=3DMsoNormal><font size=3D2 color=3Dnavy face=3DArial><span = style=3D'font-size: 10.0pt;font-family:Arial;color:navy'> </span></font></p> <p class=3DMsoNormal><font size=3D2 color=3Dnavy face=3DArial><span = style=3D'font-size: 10.0pt;font-family:Arial;color:navy'>Good catch. I verified that both = are indeed memory leaks and that your modifications were appropriate. We = will include these modifications in the next SFL patch or = release.</span></font></p> <p class=3DMsoNormal><font size=3D2 color=3Dnavy face=3DArial><span = style=3D'font-size: 10.0pt;font-family:Arial;color:navy'> </span></font></p> <p class=3DMsoNormal><font size=3D2 color=3Dnavy face=3DArial><span = style=3D'font-size: 10.0pt;font-family:Arial;color:navy'>Thanks,</span></font></p> <p class=3DMsoNormal><font size=3D2 color=3Dnavy face=3DArial><span = style=3D'font-size: 10.0pt;font-family:Arial;color:navy'> </span></font></p> <p class=3DMsoNormal><font size=3D2 color=3Dnavy face=3DArial><span = style=3D'font-size: 10.0pt;font-family:Arial;color:navy'>Tom Horvath<br> Principal Security Systems Engineer<br> _______________________________<br> BAE SYSTEMS Information Technology<br> 141 National Business Pkwy. Suite 210<br> Annapolis Junction, MD 20701</span></font></p> <p class=3DMsoNormal><font size=3D2 color=3Dnavy face=3DArial><span = style=3D'font-size: 10.0pt;font-family:Arial;color:navy'>[email protected]<br> (301) 939-2728</span></font></p> <div> <div class=3DMsoNormal align=3Dcenter style=3D'text-align:center'><font = size=3D2 color=3Dnavy face=3DArial><span = style=3D'font-size:10.0pt;font-family:Arial; color:navy'> <hr size=3D2 width=3D"100%" align=3Dcenter> </span></font></div> <p class=3DMsoNormal><b><font size=3D2 face=3DTahoma><span = style=3D'font-size:10.0pt; font-family:Tahoma;font-weight:bold'>From:</span></font></b><font = size=3D2 face=3DTahoma><span style=3D'font-size:10.0pt;font-family:Tahoma'> = Michel Kinasz [mailto:[email protected]] <br> <b><span style=3D'font-weight:bold'>Sent:</span></b> Tuesday, April 26, = 2005 4:53 PM<br> <b><span style=3D'font-weight:bold'>To:</span></b> Horvath, Tom<br> <b><span style=3D'font-weight:bold'>Subject:</span></b> SFL Memory Leaks = </span></font></p> </div> <p class=3DMsoNormal><font size=3D3 face=3D"Times New Roman"><span = style=3D'font-size: 12.0pt'> </span></font></p> <p><font size=3D2 face=3D"Times New Roman"><span = style=3D'font-size:10.0pt'>Hello Tom,</span></font> </p> <p><font size=3D2 face=3D"Times New Roman"><span = style=3D'font-size:10.0pt'>I am using SFL 2.5 with visual studio 6.0.</span></font> </p> <p><font size=3D2 face=3D"Times New Roman"><span = style=3D'font-size:10.0pt'>I had to modify SFL sources to fix some memory leaks:</span></font> </p> <p><font size=3D2 face=3D"Times New Roman"><span = style=3D'font-size:10.0pt'>sm_SignBuf.cpp Line 226:</span></font> </p> <p><font size=3D2 face=3D"Times New Roman"><span = style=3D'font-size:10.0pt'>Changed</span></font> </p> <p><font size=3D2 face=3D"Times New Roman"><span = style=3D'font-size:10.0pt'> &nbs= p; if (*pTmpAlg =3D=3D oidDigestEncryption)</span></font> <br> <font size=3D2><span = style=3D'font-size:10.0pt'> &nbs= p; {</span></font> <br> <font size=3D2><span = style=3D'font-size:10.0pt'> &nbs= p; break;</span></font> <br> <font size=3D2><span = style=3D'font-size:10.0pt'> &nbs= p; }</span></font> </p> <p><font size=3D2 face=3D"Times New Roman"><span = style=3D'font-size:10.0pt'>To</span></font> </p> <p><font size=3D2 face=3D"Times New Roman"><span = style=3D'font-size:10.0pt'> &nbs= p; if (*pTmpAlg =3D=3D oidDigestEncryption)</span></font> <br> <font size=3D2><span = style=3D'font-size:10.0pt'> &nbs= p; {</span></font> <br> <font size=3D2><span = style=3D'font-size:10.0pt'> &nbs= p; break;</span></font> <br> <font size=3D2><span = style=3D'font-size:10.0pt'> &nbs= p; }</span></font> <br> <font size=3D2><span = style=3D'font-size:10.0pt'> &nbs= p; else</span></font> <br> <font size=3D2><span = style=3D'font-size:10.0pt'> &nbs= p; {</span></font> <br> <font size=3D2><span = style=3D'font-size: 10.0pt'>free(pTmpAlg);</span></font> <br> <font size=3D2><span = style=3D'font-size: 10.0pt'>pTmpAlg =3D NULL;</span></font> <br> <font size=3D2><span = style=3D'font-size:10.0pt'> &nbs= p; }</span></font> </p> <p class=3DMsoNormal><font size=3D3 face=3D"Times New Roman"><span = style=3D'font-size: 12.0pt'> </span></font></p> <p><font size=3D2 face=3D"Times New Roman"><span = style=3D'font-size:10.0pt'>sm_free3_RSA.cpp Line 2123</span></font> </p> <p><font size=3D2 face=3D"Times New Roman"><span = style=3D'font-size:10.0pt'>Added</span></font> </p> <p><font size=3D3 face=3D"Times New Roman"><span = style=3D'font-size:12.0pt'> </span></font><font size=3D2><span style=3D'font-size:10.0pt'>if (NULL = !=3D pszPasswordMAC)</span></font> <br> <font size=3D2><span = style=3D'font-size: 10.0pt'>{</span></font> <br> <font size=3D2><span = style=3D'font-size: 10.0pt'>free(pszPasswordMAC);</span></font> <br> <font size=3D2><span = style=3D'font-size: 10.0pt'>pszPasswordMAC =3D NULL;</span></font> <br> <font size=3D2><span = style=3D'font-size: 10.0pt'>}</span></font> </p> <p><font size=3D2 face=3D"Times New Roman"><span = style=3D'font-size:10.0pt'>Could you confirm that these modifications are valid?</span></font> </p> <p><font size=3D2 face=3D"Times New Roman"><span = style=3D'font-size:10.0pt'>Thanks,</span></font> </p> <p><font size=3D2 face=3D"Times New Roman"><span = style=3D'font-size:10.0pt'>Michel Kinasz</span></font> <br> <font size=3D2><span style=3D'font-size:10.0pt'>ImageWare Systems = Inc.</span></font> </p> <p class=3DMsoNormal style=3D'margin-bottom:12.0pt'><font size=3D3 face=3D"Times New Roman"><span = style=3D'font-size:12.0pt'> </span></font></p> <p><font size=3D2 face=3D"Times New Roman"><span = style=3D'font-size:10.0pt'>The information contained in this transmission contains potentially = privileged, export controlled and/or confidential information of Imageware Systems, = Inc. or its customers or partners. It is intended only to be read by the person(s) named above and for no other purpose. You are hereby = notified that any dissemination, distribution, duplication of this communication = or use of its contents for any purpose not authorized expressly by Imageware = Systems, Inc. is strictly prohibited and could lead to both civil and/or criminal penalties. If you are not the intended recipient, you are = prohibited to review the contents herein and please contact the sender by reply e-mail = and destroy all copies of the original message. To reply to our e-mail administrator directly, please send an e-mail to = [email protected]</span></font></p> </div> </body> </html> ------_=_NextPart_001_01C54CE7.B1C7CA0E--