Re: WGLC of draft-ietf-xmpp-websocket-02

Florian Zeitz <[email protected]>
Newsgroups gmane.ietf.xmpp
Message-ID <[email protected]>
I generally consider this draft to be in a decent shape. The wording and
general flow still seem a bit rough to me at times. More detailed
comments below:

= Substantive =
* Having some text explaining the general framing approach upfront
  would be helpful. This should note that an XML Stream is not used as
  described in RFC 6120, but <open/> and <close/> elements are used
  instead. The lack of a surrounding <stream:stream> element should
  be explicitly noted. This could go along with text explaining each
  message is a full XML document without an XML declaration.

3.5 Closing the connection:
 * "To initiate closing the WebSocket connection, the closing party MUST
   send a normal WebSocket close message with an empty body."
   Why? Having no body at all implies that sending a status code
   is not allowed. This seems undesirable to me.

3.5.1 see-other-uri
 * This currently says that the URI may only point to another WebSocket
   endpoint. IIRC the intent was specifically to be able to also move
   from WebSocket to BOSH.

= Editorial =
1. Introduction:
 * "The WebSocket protocol [...]. The WebSocket protocol [...]."

3.3 XMPP Stream Setup
 * It would be helpful to reuse RFC 6120's language here.
   I.e. "The first message sent by the initiating entity [...]"
   "The receiving entity MUST respond [...]"

3.6 Stanzas
 * "directly over the XMPP stream", RFC 6120 calls this a "XML Stream".
 * "XML text declaration" XML 1.0 calls this a "XML declaration",
   the whole sentence could use some rewording, possibly also mentioning
   size overhead.

3.7 Stream Restarts
 * "In these cases", only one case is listed. Possibly reword to say
   something like "Whenever a stream restart is mandated [...]"
   Clarify <open/> is used for stream restarts instead of
   <stream:stream>.

3.8 Stanzas
 * "that the XMPP stream is still alive" -> "XML Stream"

Regards,
Florian Zeitz


On 07.04.2014 23:29, Ben Campbell wrote:
> This is a Working Group Last Call of draft-ietf-xmpp-websocket-02. The draft is available at the following URL:
> 
> http://tools.ietf.org/html/draft-ietf-xmpp-websocket-02
> 
> The WGLC will conclude on 21 April, 2014. Please send your comments to the authors and the XMPP mailing list.
> 
> Thanks!
> 
> Ben.
>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.