Re: [PATCH v3 07/10] ACPI: extlog: Fix CONFIG_ACPI_APEI_PCIEAER guard typo
Shuai Xue <[email protected]> Wed, 12 Aug 2026 21:10:27 +0800
| Newsgroups | gmane.linux.acpi.devel |
|---|---|
| Message-ID | <[email protected]> |
On 7/18/26 12:16 AM, Dave Jiang wrote: > sashiko-bot flagged that a Kconfig macro typo compiles out the extlog > CXL protocol error handling entirely. > > The guard reads "#ifdef ACPI_APEI_PCIEAER" instead of > "#ifdef CONFIG_ACPI_APEI_PCIEAER", so the wrapped code is always compiled > out. Use the correct CONFIG_ prefixed symbol. > > Reported-by: [email protected] > Fixes: 95350effc3ad ("ACPI: extlog: Trace CPER CXL Protocol Error Section") > Assisted-by: Claude:claude-opus-4-8 > Reviewed-by: Ben Cheatham <[email protected]> > Signed-off-by: Dave Jiang <[email protected]> > --- > drivers/acpi/acpi_extlog.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/acpi_extlog.c b/drivers/acpi/acpi_extlog.c > index ae79d090de33..1fbaf134c04e 100644 > --- a/drivers/acpi/acpi_extlog.c > +++ b/drivers/acpi/acpi_extlog.c > @@ -136,7 +136,7 @@ static int print_extlog_rcd(const char *pfx, > static void extlog_print_pcie(struct cper_sec_pcie *pcie_err, > int severity, u32 len) > { > -#ifdef ACPI_APEI_PCIEAER > +#ifdef CONFIG_ACPI_APEI_PCIEAER > struct aer_capability_regs aer_regs = {}; > struct aer_capability_regs *aer; > struct pci_dev *pdev; Reviewed-by: Shuai Xue <[email protected]> Thanks. Shuai