Re: [PATCH] gpiolib: acpi: Add ignore_wake quirk for ASUS ZenBook UX425UA_UM425UA
Mario Limonciello <[email protected]>
| Newsgroups | gmane.linux.acpi.devel,gmane.linux.kernel.gpio,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
On 8/21/26 16:46, Aviv wrote: > Hi Mario, > > Nothing is physically connected to GPP3. The bridge (00:02.1 / > \_SB.PCI0.GPP3) is unpopulated on this board (the ZenBook UX425UA has > no Ethernet or secondary PCIe devices there). > > The DSDT seems to have leftover definitions for RTL8/RUSB on GPP3 from > a shared BIOS base, and routes GPIO pin 24 to it in _EVT, causing > phantom wake events during s2idle. > > Here is the acpidump: > https://gist.github.com/vaknin/142f5cbad15958e9025cd81960114f6e > > Thanks, > Kivan Thanks. The dump agrees with your assessment. Reviewed-by: Mario Limonciello (AMD) <[email protected]>> > > On Fri, Aug 21, 2026 at 11:49 PM Mario Limonciello > <[email protected]> wrote: >> >> What is connected to this GPP3? >> >> Can you please share your acpidump somewhere? >> >> On 8/21/26 02:06, Kivan wrote: >>> The ASUS ZenBook UX425UA_UM425UA (with AMD Ryzen 7 5700U SoC) fails >>> to stay suspended in s2idle (Modern Standby), prematurely waking >>> after 1-3 seconds with 0% hardware sleep achieved. >>> >>> In the laptop's ACPI SSDT tables (SSDT15), GPIO Pin 24 (hex 0x18) is >>> defined in _AEI as ExclusiveAndWake targeting the PCIe bridge device >>> \_SB.PCI0.GPP3: >>> >>> GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone, 0x0000, >>> "\\_SB.GPIO", ...) { 0x0018 } >>> >>> When the SoC powers down PCIe root ports into low-power states during >>> s2idle, an electrical edge transition triggers a spurious wake interrupt >>> on GPIO Pin 24. This signals the AMD GPIO controller (AMDI0030:00 / IRQ 7 >>> via pinctrl_amd), aborting sleep across the system. >>> >>> Booting with kernel parameter "gpiolib_acpi.ignore_wake=AMDI0030:00@24" >>> completely resolves the issue: amd_gpio reports ignoring the wakeup on >>> pin 24, and interrupt counts in /proc/interrupts remain at 0 during sleep >>> cycles, allowing uninterrupted s2idle until intentionally woken by the >>> user. >>> >>> Add a DMI quirk entry to ignore wake events on AMDI0030:00@24 for this >>> system. >>> >>> Signed-off-by: Kivan <[email protected]> >>> --- >>> drivers/gpio/gpiolib-acpi-quirks.c | 13 +++++++++++++ >>> 1 file changed, 13 insertions(+) >>> >>> diff --git a/drivers/gpio/gpiolib-acpi-quirks.c b/drivers/gpio/gpiolib-acpi-quirks.c >>> index a0116f0..dd4db58 100644 >>> --- a/drivers/gpio/gpiolib-acpi-quirks.c >>> +++ b/drivers/gpio/gpiolib-acpi-quirks.c >>> @@ -392,6 +392,19 @@ static const struct dmi_system_id gpiolib_acpi_quirks[] __initconst = { >>> .ignore_wake = "VEN_0488:00@355", >>> }, >>> }, >>> + { >>> + /* >>> + * Spurious wakeups from GPP3 PCIe bridge interrupt >>> + * Found in BIOS UX425UA.301 >>> + */ >>> + .matches = { >>> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), >>> + DMI_MATCH(DMI_PRODUCT_NAME, "ZenBook UX425UA_UM425UA"), >>> + }, >>> + .driver_data = &(struct acpi_gpiolib_dmi_quirk) { >>> + .ignore_wake = "AMDI0030:00@24", >>> + }, >>> + }, >>> {} /* Terminating entry */ >>> }; >>> >>