Re: [PATCH 5.10.y v1] ALSA: usb-audio: Evaluate packsize caps at the right place
Sasha Levin <[email protected]>
| Newsgroups | gmane.linux.kernel.stable,gmane.linux.alsa.devel |
|---|---|
| Message-ID | <[email protected]> |
> diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c > @@ -953,6 +953,13 @@ static int snd_usb_pcm_prepare(struct snd_pcm_substream *substream) > + subs->data_endpoint->packsize[0] = min( > + subs->data_endpoint->packsize[0], > + subs->data_endpoint->maxframesize); Moving the cap into snd_usb_pcm_prepare() is the right call for 5.10 - that tree never computes ep->maxframesize inside snd_usb_endpoint_set_params(), so there is nowhere in that function to move it to - but nothing in the changelog says that. Please send a v2 that spells the relocation out in the commit message, since the diff no longer matches upstream. Two other things before I can take it: - The Signed-off-by needs your real name; a handle does not satisfy the DCO. - An ack from Takashi on the 5.10 placement, he's already on Cc. -- Thanks, Sasha