Re: Set deactivation

Phillip Susi <[email protected]> Mon, 8 Dec 2008 11:29:40 -0500
Newsgroups gmane.linux.ataraid
Message-ID <[email protected]>
Heinz Mauelshagen wrote:
>> They both call dmraid_uuid for DM_DEVICE_CREATE.
> 
> No, -rc15 does set the UUID, -rc14 doesn't.
> 
>>  The difference is that 
>> rc14 only calls dm_task_run for DM_DEVICE_CREATE,
> 
> No, -rc14 calls dm_task_run for both DM_DEVICE_CREATE and
> DM_DEVICE_REMOVE:

<snip>

>         ret = (dmt = dm_task_create(type)) && dm_task_set_name(dmt,
> rs->name);
>         if (ret && table)
>                 ret = parse_table(lc, dmt, table);
> 
> /**** Here dm_task_run() is being called for *and* type, unless dm
> infrastructure or table parse failure ****/
>        if (ret)
>                 ret = dm_task_run(dmt);

Nevermind... we've been looking at different code because I forgot to 
revert the debian/ubuntu dpatches and it seems one of them adds UUID 
support to rc14, and looks like it does so incorrectly because it 
prevents dm_task_run() from being called for type != DM_DEVICE_CREATE.