Re: ToneShiftEQ v0.3.0 — First public relea se

Hermann Meyer <brummer--S0/[email protected]> Sun, 5 Jul 2026 05:24:19 +0200
Newsgroups	gmane.linux.audio.devel
Message-ID	<[email protected]>
This is a multi-part message in MIME format.
--------------7VMze7rWjR6swnRdau3qNpWE
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable


Am 03.07.26 um 21:52 schrieb Fons Adriaensen:
> On Fri, Jul 03, 2026 at 07:28:05PM +0200, Hermann Meyer wrote:
>  =20
>> Am 03.07.26 um 16:36 schrieb Fons Adriaensen:
>>> Master mode ('Live' shown in the GUI): 128 samples
>>> Live mode ('Master' shown in the GUI): 256 samples
>>
>> Okay, I can't reproduce the mismatch of Master is active but live is sh=
own,
>> but, I could reproduce the latency of the live convolver. Seems it is b=
roken
>> on the way.=C2=A0 I'll fix or remove it. Master convolver still stands =
as 128 as
>> stated. This is the phase response as shown by Ardour,
>>
>> https://i.imgur.com/tFNvMhp.png
> Which is clearly not linear phase.
>
> The little script I used is freqresp4.py in examples/JackSignal.
> You'll need version 1.8.0, uploaded a few minutes ago.
>
> You can of course replace zita-eq1 by anything else that has
> zero latency, or just leave the second input unconnected.
> I just added zita-eq1 to be verify that the latency is shown
> correctly.
>

Thanks for the feedback on ToneShiftEQ.
Even if your first response was very harsh, it was technically correct=20
and helps me to fix a couple of issues. So, thanks for that.

What I've done now:

  * Fix documentation to state that it is a minimum-phase system.
  * Remove Live mode, as it was broken and therewith useless.
  * Fix shelf filters.
  * Implement phase analyzer to allow inspecting the phase response.

regards
hermann

--------------7VMze7rWjR6swnRdau3qNpWE
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3DUTF-=
8">
  </head>
  <body>
    <p><br>
    </p>
    <div class=3D"moz-cite-prefix">Am 03.07.26 um 21:52 schrieb Fons
      Adriaensen:<br>
    </div>
    <blockquote type=3D"cite"
      cite=3D"mid:akgS8PO7uwD0laCN-i9wRM+HIrmlcsMIzqIq2i0B+6BGkLq7r@public.gmane.org">
      <pre wrap=3D"" class=3D"moz-quote-pre">On Fri, Jul 03, 2026 at 07:28=
:05PM +0200, Hermann Meyer wrote:
=20
</pre>
      <blockquote type=3D"cite">
        <pre wrap=3D"" class=3D"moz-quote-pre">Am 03.07.26 um 16:36 schrie=
b Fons Adriaensen:
</pre>
        <blockquote type=3D"cite">
          <pre wrap=3D"" class=3D"moz-quote-pre">Master mode ('Live' shown=
 in the GUI): 128 samples
Live mode ('Master' shown in the GUI): 256 samples
</pre>
        </blockquote>
        <pre wrap=3D"" class=3D"moz-quote-pre">

Okay, I can't reproduce the mismatch of Master is active but live is shown=
,
but, I could reproduce the latency of the live convolver. Seems it is brok=
en
on the way.=C2=A0 I'll fix or remove it. Master convolver still stands as =
128 as
stated. This is the phase response as shown by Ardour,

<a class=3D"moz-txt-link-freetext" href=3D"https://i.imgur.com/tFNvMhp.png=
">https://i.imgur.com/tFNvMhp.png</a>
</pre>
      </blockquote>
      <pre wrap=3D"" class=3D"moz-quote-pre">
Which is clearly not linear phase.

The little script I used is freqresp4.py in examples/JackSignal.
You'll need version 1.8.0, uploaded a few minutes ago.

You can of course replace zita-eq1 by anything else that has
zero latency, or just leave the second input unconnected.=20
I just added zita-eq1 to be verify that the latency is shown
correctly.

</pre>
    </blockquote>
    <p><br>
    </p>
    <p class=3D"font-claude-response-body break-words whitespace-normal">T=
hanks
      for the feedback on ToneShiftEQ.<br>
      Even if your first response was very harsh, it was technically
      correct and helps me to fix a couple of issues. So, thanks for
      that.</p>
    <p class=3D"font-claude-response-body break-words whitespace-normal">W=
hat
      I've done now:</p>
    <ul
class=3D"[li_&amp;]:mb-0 [li_&amp;]:mt-1 [li_&amp;]:gap-1 [&amp;:not(:last=
-child)_ul]:pb-1 [&amp;:not(:last-child)_ol]:pb-1 list-disc flex flex-col =
gap-1 pl-8 mb-3">
      <li
class=3D"font-claude-response-body whitespace-normal break-words pl-2">Fix
        documentation to state that it is a minimum-phase system.</li>
      <li
class=3D"font-claude-response-body whitespace-normal break-words pl-2">Rem=
ove
        Live mode, as it was broken and therewith useless.</li>
      <li
class=3D"font-claude-response-body whitespace-normal break-words pl-2">Fix
        shelf filters.</li>
      <li
class=3D"font-claude-response-body whitespace-normal break-words pl-2">Imp=
lement
        phase analyzer to allow inspecting the phase response.</li>
    </ul>
    <p class=3D"font-claude-response-body break-words whitespace-normal">r=
egards<br>
      hermann</p>
  </body>
</html>

--------------7VMze7rWjR6swnRdau3qNpWE--