Re: [RFC] Pre-Memory Sign-of-Life using Intel uGOP

On 23.08.23 11:32, Arthur Heymans wrote:
>>> ReportStatusCode() to report debug information which coreboot prints
> using printk.
>> can you point me to the code integrating this? I could find this
> identifier only in vendorcode/ headers. Is it for debugging?
>
> I meant code calling back to the coreboot console in general for debugging.
> A few examples:
> 1)
> https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src/northbridge/intel/sandybridge/raminit_mrc.c#153
> 2)
> https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src/drivers/intel/fsp2_0/fsp_debug_event.c#20

Thanks, seems ok to me to use it for debugging.

>> I thought this was kept optional--one of the many things dumped into our
> repo that didn't take off.
> Just checked and it's enabled by default oO, but I could disable it and
> coreboot built.
> Does anybody use this PPI "feature" in a product?
>
> I thought the CPU PPI was enabled by default and necessary(?) on all Intel
> products (except xeon-sp) since Intel Icelake.

That is what we were told initially, but then the `SkipMpInit` UPD
stayed and there was effort to keep it working, e.g.

  8409f156d588 (soc/intel/alderlake: Remove dependency of FSP-S CpuMpPei
Module)

Grepping right now, this seems to be missing for Meteor Lake, though.

Nico

_______________________________________________
coreboot mailing list -- [email protected]
To unsubscribe send an email to [email protected]