Re: How to get reviews on gerrit? aka. patches ignored for three years.

Hello Daniel,

Thank you for contributing to the coreboot project. Each contribution is
important and should be taken care of.

> could someone tell me how I'm supposed to deal with unresponsive
reviewers on gerrit?

Typically patches are reviewed in few days from assigning reviewers
assuming they are available at the time. If they are not, then emails might
get buried in their mailbox. If that case you can simply ping reviewers by
adding general patch comment with "@Name" for their attention.
If you have problems with finding maintainers in MAINTAINERS file you can
use ./util/scripts/get_maintainer.pl script to find potential candidates.

> Clearly I must be doing something wrong as the patches have been
gathering dust for around three years now.

There might be few reasons for that. First, for patch to be eligible for
review it cannot have merge conflicts as resolving them might change patch
contents and will most certainly drop all CR+ scores and invalidate some
comments. You should try keep patches in mergable state. Second, submitting
long patch trains usually makes reviewers to halt until previous patches
are reviewed, as changes in patches earlier in the train might invalidate
their time put into reviewing. I'd suggest focusing on earlier patches
first, merging them and gradually moving to later ones.

Best Regards,
Jakub

On Fri, Sep 29, 2023 at 2:15 PM Christian Walter <
[email protected]> wrote:

> Hi Daniel,
>
> thanks for the constructive feedback. The coreboot community is a very
> active community. We review hundreds of patches every day and I am sorry
> that we missed to review your patches.
>
> I guess the best idea here is to ping people on either IRC, Matrix or
> Slack. Also a friendly question if someone has time to review your patches
> via the mailing list is for sure feasible. Especially if you point out that
> you have a high interest in getting the patches in.
>
> A good idea is also to review patches on gerrit in order to take more work
> load _off_ the coreboot reviewers so they eventually have more time for
> your patches. As always, you get back what you put in.
>
> Hope that helps!
>
> Chris
> On 9/29/23 11:41, Daniel Gröber wrote:
>
> Hi,
>
> could someone tell me how I'm supposed to deal with unresponsive reviewers
> on gerrit? Clearly I must be doing something wrong as the patches have been
> gathering dust for around three years now.
> https://review.coreboot.org/q/topic:%22macronix-spi-bp%22
>
> --Daniel
> _______________________________________________
> coreboot mailing list -- [email protected]
> To unsubscribe send an email to [email protected]
>
> --
> *Christian Walter*
> *Head of Firmware Development / Cyber Security *
>
>
>
> 9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
> Email:  [email protected]
> Phone:  *+49 234 68 94 188 <+492346894188>*
> Mobile:  *+49 176 70845047 <+4917670845047>*
>
> Sitz der Gesellschaft: Bochum
> Handelsregister: Amtsgericht Bochum, HRB 17519
> Geschäftsführung: Sebastian Deutsch, Eray Basar
>
> Datenschutzhinweise nach Art. 13 DSGVO <https://9elements.com/privacy>
> _______________________________________________
> coreboot mailing list -- [email protected]
> To unsubscribe send an email to [email protected]
>

_______________________________________________
coreboot mailing list -- [email protected]
To unsubscribe send an email to [email protected]