Re: geminilake fsp on Google Chromebook?

On Fri, Dec 8, 2023 at 10:53 PM James Feeney via coreboot <
[email protected]> wrote:

> Comparing the git trees for the current stock coreboot and for your
> MrChromebox-4.21, I'm wondering about the .config differences generated by
> nconfig at CONFIG_FSP_HEADER_PATH=.
>
> ./src/soc/intel/apollolake/Kconfig has:
>
>  config FSP_HEADER_PATH
>         default "src/vendorcode/intel/fsp/fsp2_0/geminilake/2.2.0.0" if
> VENDOR_GOOGLE && SOC_INTEL_GEMINILAKE
>         default "src/vendorcode/intel/fsp/fsp2_0/geminilake/2.2.3.1" if
> SOC_INTEL_GEMINILAKE
>         default "3rdparty/fsp/ApolloLakeFspBinPkg/Include/"
>
> But, "make nconfig" in the MrChromebox tree, nonetheless, produces
> 'CONFIG_FSP_HEADER_PATH="src/vendorcode/intel/fsp/fsp2_0/geminilake/
> 2.2.3.1"' in the .config, somehow, despite the above, while the stock
> coreboot "make nconfig" instead produces
> 'CONFIG_FSP_HEADER_PATH="src/vendorcode/intel/fsp/fsp2_0/geminilake/
> 2.2.0.0"', as might be expected.
>

I override it in my site-local/Kconfig:

https://github.com/MrChromebox/coreboot/blob/MrChromebox-4.21/site-local/Kconfig#L38


>
> Can someone explain why there is the "if VENDOR_GOOGLE &&
> SOC_INTEL_GEMINILAKE" consraint for the fsp?
>
> Is fsp 2.2.3.1 actually still the correct configuration when using the
> fsp.bin files extracted from the stock Google ChromeOS?
>

it's not, but I don't use the fsp*.bin files extracted from the stock
ChromeOS firmware images for GLK boards.


>
> Thanks
> James
>
> _______________________________________________
> coreboot mailing list -- [email protected]
> To unsubscribe send an email to [email protected]
>

_______________________________________________
coreboot mailing list -- [email protected]
To unsubscribe send an email to [email protected]