New Defects reported by Coverity Scan for coreboot

Hi,

Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan.

3 new defect(s) introduced to coreboot found with Coverity Scan.
721 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1612379:       Control flow issues  (DEADCODE)
/src/acpi/acpi.c: 1124           in acpi_create_fadt()


_____________________________________________________________________________________________
*** CID 1612379:         Control flow issues  (DEADCODE)
/src/acpi/acpi.c: 1124             in acpi_create_fadt()
1118     		fadt->x_firmware_ctl_h = (uint32_t)((uint64_t)(uintptr_t)facs >> 32);
1119     	fadt->x_firmware_ctl_l = (uint32_t)(uintptr_t)facs;
1120     
1121     	if ((uintptr_t)dsdt <= UINT32_MAX)
1122     		fadt->dsdt = (uintptr_t)dsdt;
1123     	else
>>>     CID 1612379:         Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "fadt->x_dsdt_h = (uint32_t)...".
1124     		fadt->x_dsdt_h = (uint32_t)((uint64_t)(uintptr_t)dsdt >> 32);
1125     	fadt->x_dsdt_l = (uint32_t)(uintptr_t)dsdt;
1126     
1127     	/* should be 0 ACPI 3.0 */
1128     	fadt->reserved = 0;
1129     

** CID 1612378:       Control flow issues  (DEADCODE)
/src/acpi/acpi.c: 1594           in write_acpi_tables()


_____________________________________________________________________________________________
*** CID 1612378:         Control flow issues  (DEADCODE)
/src/acpi/acpi.c: 1594             in write_acpi_tables()
1588     	current = acpi_align_current(current);
1589     	if (current + sizeof(acpi_rsdt_t) - 1 <= UINT32_MAX) {
1590     		rsdt = (acpi_rsdt_t *)current;
1591     		current += sizeof(acpi_rsdt_t);
1592     		current = acpi_align_current(current);
1593     	} else {
>>>     CID 1612378:         Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "printk(6, "Not adding RSDT ...".
1594     		printk(BIOS_INFO, "Not adding RSDT because tables reside above 4G.");
1595     	}
1596     
1597     	xsdt = (acpi_xsdt_t *)current;
1598     	current += sizeof(acpi_xsdt_t);
1599     	current = acpi_align_current(current);

** CID 1612377:       Control flow issues  (DEADCODE)
/src/acpi/acpi.c: 1118           in acpi_create_fadt()


_____________________________________________________________________________________________
*** CID 1612377:         Control flow issues  (DEADCODE)
/src/acpi/acpi.c: 1118             in acpi_create_fadt()
1112     		return;
1113     
1114     	fadt->FADT_MinorVersion = get_acpi_fadt_minor_version();
1115     	if ((uintptr_t)facs <= UINT32_MAX)
1116     		fadt->firmware_ctrl = (uintptr_t)facs;
1117     	else
>>>     CID 1612377:         Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "fadt->x_firmware_ctl_h = (u...".
1118     		fadt->x_firmware_ctl_h = (uint32_t)((uint64_t)(uintptr_t)facs >> 32);
1119     	fadt->x_firmware_ctl_l = (uint32_t)(uintptr_t)facs;
1120     
1121     	if ((uintptr_t)dsdt <= UINT32_MAX)
1122     		fadt->dsdt = (uintptr_t)dsdt;
1123     	else


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/coreboot?tab=overview

_______________________________________________
coreboot mailing list -- [email protected]
To unsubscribe send an email to [email protected]