Re: My review is strange (problems on the system)
David Hendricks <[email protected]> Fri, 31 Jul 2026 12:37:08 -0700
| Newsgroups | gmane.linux.bios |
|---|---|
| Message-ID | <CAJ_ov55Y6MC+9KuMMEFDSKNifgNh7W1B0q0_EssnVKmLZBPhMw@mail.gmail.com> |
--===============2272234062119623394== Content-Type: multipart/alternative; boundary="0000000000000989980657ed52cc" --0000000000000989980657ed52cc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable There was a lot of churn in https://review.coreboot.org/c/coreboot/+/93439 which I assume is the patch you are referring to. Like you say no unresolved comments show up in the UI, so I guess there is some inconsistent state in gerrit. Our gerrit instance was recently upgraded, hopefully this isn't a widespread problem... Anyway, if a reviewer +2's it then we'll get it merged. P.S. Please don't spam the security@ or other unrelated mailing lists. [email protected] is the correct mailing list for this sort of thing. On Fri, Jul 31, 2026 at 10:04=E2=80=AFAM Paulo Alexandre A.P. de Oliveira < [email protected]> wrote: > Hi, > > i'm trying to put together a merge of the macbookpro14.1 support on the > coreboot bios, as you can see in the pdf attached, i see no unresolved > comment, yet my AI and the system says that there are unresolved comment'= s. > > How many i cannot see. My view says all resolved. > > Can you check that for me? > _______________________________________________ > coreboot mailing list -- [email protected] > To unsubscribe send an email to [email protected] > --0000000000000989980657ed52cc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>There was a lot of churn in <a href=3D"https://review= .coreboot.org/c/coreboot/+/93439">https://review.coreboot.org/c/coreboot/+/= 93439</a> which I assume is the patch you are referring to. Like you say no= unresolved comments show up in the UI, so I guess there is some inconsiste= nt state in gerrit. Our gerrit instance was recently upgraded, hopefully th= is isn't a widespread problem...</div><div><br></div><div>Anyway, if a = reviewer=C2=A0+2's it then we'll get it merged.</div><div><br></div= ><div><span style=3D"background-color:transparent">P.S. Please don't sp= am the security@ or other unrelated mailing lists. <a href=3D"mailto:corebo= [email protected]">[email protected]</a> is the correct mailing list for = this sort of thing.</span></div></div><br><div class=3D"gmail_quote gmail_q= uote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, Jul 31, 2026 = at 10:04=E2=80=AFAM Paulo Alexandre A.P. de Oliveira <<a href=3D"mailto:= [email protected]">[email protected]</a>> wrot= e:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0= .8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br> <br> i'm trying to put together a merge of the macbookpro14.1 support on the= <br> coreboot bios, as you can see in the pdf attached, i see no unresolved <br> comment, yet my AI and the system says that there are unresolved comment= 9;s.<br> <br> How many i cannot see. My view says all resolved.<br> <br> Can you check that for me?<br> _______________________________________________<br> coreboot mailing list -- <a href=3D"mailto:[email protected]" target=3D= "_blank">[email protected]</a><br> To unsubscribe send an email to <a href=3D"mailto:[email protected]= rg" target=3D"_blank">[email protected]</a><br> </blockquote></div> --0000000000000989980657ed52cc-- --===============2272234062119623394== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ coreboot mailing list -- [email protected] To unsubscribe send an email to [email protected] --===============2272234062119623394==--