Re: [PATCH] Split agents

Marcel Holtmann <[email protected]>
Newsgroups gmane.linux.bluez.devel
Message-ID <1202606464.7664.27.camel@violet>
Hi Bastien,

> > > First draft patch to split the agents away from the main program. Seems
> > > to work fine for me.
> > > 
> > > This is mostly moving functions around though.
> > 
> > Updated patch following the comments from Marcel.
> 
> Patch that compiles again.

I like the split of the notifications. Can we do that first in a
separate patch. Looks simple enough and makes the history a lot cleaner
compared to a big one.

Three small things with it:

* Please use notify.[ch] as filename. I don't like too long file names.
* No need to include <glib/gi18n.h>. No translations in this file.
* I saw some whitespaces and empty line things mistakes.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.