Re: [PATCH] Launch browser / email client when clicking on link in about dialogs

On Feb 10, 2008 9:39 PM, Marcel Holtmann <[email protected]> wrote:
> Hi Jaap,
>
> > > Another patch
> > > http://bugzilla.gnome.org/show_bug.cgi?id=515581
> >
> > can you fix the coding style please. There are white spaces that
> > shouldn't be there.

Sorry. I try not to put spaces, but it's difficult to change a habit.
I'll try checking better when sending you a patch next time.


> never mind. Did it by myself. Just two minor things.
>
> First, I am picky about the coding style. Always have been and always
> will be. The code must look sane and not as some hackish crap. Also
> having the coding style in place in the first place makes my life easier
> and patching is a lot simpler.

Will do my best

> Second, please don't put patches into Bugzilla. I stated before that I
> don't care about the GNOME Bugzilla. If you wanna do that, fine, but
> then send a copy to the mailing list (not some link). This is the place
> where I pick them up. Otherwise the will go unseen and end up in
> nirvana.
>
I personally feel the other way around. I tend to loose track of
emails, so I prefer bugzilla.

But it's not a problem for me to also attach it, if you prefer that

Jaap

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/