Re: forcing SCO connection patch
"Brad Midgley" <[email protected]>
| Newsgroups | gmane.linux.bluez.devel |
|---|---|
| Message-ID | <[email protected]> |
Louis > When I tried to connect SCO channel with > HCI_OP_SETUP_SYNC_CONN(LINK_TYPE_ESCO), some bluetooth headsets responds > with LINK_TYPE_SCO because it did not support ESCO. But bluez couldn't > handle this situation, and patch_hci_event.c is for this. Marcel looked at this patch and came back with the comments below. Can you revisit it? I think some other people are seeing the same issues. The patch won't go upstream until Marcel likes it. the patch you sent me is fully broken. First of all the coding style is wrong. Does nobody have learned this by now? I always look for that first before even reading the patch. Second the case where an ESCO_LINK returns NULL is broken and will fall over and crash. -- Brad ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/