Re: [patch] alignment trap in hcid

On Feb 29, 2008, at 20:27, Marcel Holtmann wrote:
>> I recently met an alignment trap in hcid.
>> Some device sent me an sdp request and the answer had to be
>> fragmented because the device reception buffer was very small.
>> After that i saw alignment trap.
>> The last trace I saw was : Continuation state size: 8
>> The trace is located at sdpd/request.c : static sdp_cont_state_t
>> *sdp_cstate_get(uint8_t *buffer)
>> This function returns an unaligned pointer.
>
> this is so funny since I know it was there, but the new qualification
> tests don't find it anymore :)
>
> Please fix the coding style. You are missing some spaces after the  
> "if".
>
> Johan, please have second look at the patch. It looks good to me.

Looks good to me too.

Johan

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/