Bug in compat_ppoll

Hi,

When I was cross-compiling Bluez for a system without the ppoll() system
call, I've found a bug on you ppoll() stub, compat_ppoll(), that causes
rfcomm to eat all CPU power when called in this way:

$ rfcomm listen 0 1 <cmd>

After the RFCOMM connection is established and the command is executed
the CPU load reaches 100%.

This patch solved my problem:

diff -Naur bluez-utils-3.27.orig/common/ppoll.h
bluez-utils-3.27/common/ppoll.h
--- bluez-utils-3.27.orig/common/ppoll.h    2007-05-20
09:28:28.000000000 +0100
+++ bluez-utils-3.27/common/ppoll.h 2008-03-06 15:56:02.000000000 +0000
@@ -7,5 +7,10 @@
 static inline int compat_ppoll(struct pollfd *fds, nfds_t nfds,
        const struct timespec *timeout, const sigset_t *sigmask)
 {
-   return poll(fds, nfds, timeout ? timeout->tv_sec * 1000 : 500);
+   if (timeout == NULL)
+       return poll(fds, nfds, -1);
+   else if (timeout->tv_sec == 0)
+       return poll(fds, nfds, 500);
+   else
+       return poll(fds, nfds, timeout->tv_sec * 1000);
 }

Regards,
José Miguel Gonçalves


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/