Re: Wizard patch

Marcel Holtmann <[email protected]> Tue, 01 Jul 2008 03:10:53 +0200
Newsgroups gmane.linux.bluez.devel
Message-ID <[email protected]>
Hi Michael,

> > > Except that one of my other patches adds a new cancelable function
> > > _connect().  So we would need maybe specific cancel_bonding and
> > > cancel_connect functions.
> > 
> > sounds good to me. The bonding case is special since it can only do one
> > at a time.
> 
> OK, attached is callback2.diff, which only allows canceling a create_bonding call.  Updated other patches to follow.

please only change create_bonding and leave the others alone. Also you
cast a little bit too much for my taste. For example void pointers need
to extra cast.

Regards

Marcel



-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php