Re: Crash bug in bluez-4.4
Johan Hedberg <[email protected]> Mon, 8 Sep 2008 22:59:49 +0300
| Newsgroups | gmane.linux.bluez.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi Fabien, On Sep 8, 2008, at 22:44, Fabien Chevalier wrote: > Path attached fixes the bug... by removing three lines of code that > seem to me not only a premature, but also bogus optimization :-(, > that prevent us to trying to return the first element of an empty > gslist. > > However i'm not that familiar with that manager stuff and might be > wrong, so please double check that ;-) Good catch, and the patch looks good too. Another alternative would have been to change the return line to return devices ? devices->data : NULL; but you're right in that it's just an unnecessary optimization. The fix is now in the kernel.org git. Johan ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/