Re: [PATCH] libbb: rename two fields in ioloop_state, no logic changes

"Roberto A. Foglietta via busybox" <[email protected]> Tue, 21 Apr 2026 22:43:49 +0200
Newsgroups gmane.linux.busybox
Message-ID <CAJGKYO5a8GV2HnGiuGi41HjjNVZjZsuN5SH3LJ9BLEzQzNPscQ@mail.gmail.com>
On Tue, 21 Apr 2026 at 22:12, Charles Mirabile <[email protected]> wrote:
>
> Hi Roberto -
>
...
>
> $ git log --oneline --author='[email protected]'
> c8e3922ad free: add 'available' memory if provided by the kernel
> 75a1403f2 free: handle "cached" value too

procps/free.c -- line 81:

static NOINLINE unsigned int parse_meminfo(struct globals *g)
{
    char buf[60]; /* actual lines we expect are ~30 chars or less */
    FILE *fp;
    int seen_cached_and_available_and_reclaimable;

    fp = xfopen_for_read("/proc/meminfo");

What does this mean?

free() { grep -E
"MemTotal|MemFree|MemAvailable|Buffers|Cached:|SReclaimable|SwapFree|SwapTotal"
/proc/meminfo; }


> That is more patches authored by him than the single patch I found
> from your address... (though when I just grep more broadly for your
> name I see a couple more from Denys suggested by you)
> $ git log --oneline --author='[email protected]'
> e0bf3df02 ash: add bash-like ERR trap and set -E

+:git-shell:uchaosys:busybox> grep -i foglietta AUTHORS
Roberto A. Foglietta <[email protected]>

>
> Now, I say this as someone with zero official contributions to busybox

Mirabile @readhat -- shut up please! (and look below)

Update fsck_minix.c#105 -- HackingRepocommentedon Jul 18, 2025

CWE-120: Buffer Copy without Checking Size of Input

https://github.com/mirror/busybox/pull/105

+:git-shell:uchaosys:busybox> sw a65a1f9e2
commit a65a1f9e24163050181a946cf890a02442277902
Author: Roberto A. Foglietta <[email protected]>
Date:   Sat Apr 18 05:45:50 2026 +0200

    fsck_minix.c: current_name potential buffer overflow fix

    Each depth is a subfolder that requires a '/' char plus ending '0'

    Signed-off-by: Roberto A. Foglietta <[email protected]>

diff --git a/util-linux/fsck_minix.c b/util-linux/fsck_minix.c
index dd2265c32..7a24ce8e9 100644
--- a/util-linux/fsck_minix.c
+++ b/util-linux/fsck_minix.c
@@ -183,7 +183,7 @@ struct globals {
        char check_file_blk[BLOCK_SIZE];

        /* File-name data */
-       char current_name[MAX_DEPTH * MINIX_NAME_MAX];
+       char current_name[MAX_DEPTH * (MINIX_NAME_MAX + 1) + 1];
 };
 #define G (*ptr_to_globals)
 #if ENABLE_FEATURE_MINIX2


Best regards, R-