Re: [PATCH] beep: fix division by zero when -f 0 is passed
Jody Bruchon via busybox <[email protected]> Tue, 26 May 2026 12:00:02 -0400
| Newsgroups | gmane.linux.busybox |
|---|---|
| Message-ID | <[email protected]> |
On 2026-05-26 8:01 AM, tito via busybox wrote: > On Tue, 26 May 2026 11:14:48 +0300 > Anton Moryakov via busybox <[email protected]> wrote: > + if (freq < 20 || freq > 50000) Why these arbitrary numbers? Just do a simple zero check. If I want the speaker to make a pop at 1 Hz, I should be able to make it pop at 1 Hz. Also, 50 kHz is way beyond the abilities of human hearing. Anything other than if (freq == 0) error(); is bloat.