Re: om-2.6 patch for kcomd (pre-pre-alpha)

On Fri, Jul 14, 2006 at 01:36:15PM -0600, Matt Dew wrote:
> DOH! Accidentally hit send.  Sorry 'bout that.
> 
> I've put my stuff on 
> http://www.osource.org/openmosix/om-26.html
> 
> The patch is against the vanilla 2.6.16 instead of against git.
> 
> I've tested the patch on there now, om-2.6-full-20060714.patch.bz2, and
> it applies, compiles and runs.

Is that possible to have a patch against latest git ?

just some random bit of my quick review:

- do not continue after accept_connection
- spin_lock and unlock really need to be there when browsing
  (list_for_each) the nodes. why has that been uncommented ?
- some word about the CLONE_FS|CLOSE_FILES ? I believe that useful to be
  able to close all stuff from the module exit call. However that seems
  wrong .. not sure with which thread is that sharing fs/files.
- header of kcom.h is wrong, please take the one from hpc/kcom.c
- you are still allocating the socket
- lots of commented lines. that should definitively be cleaned up.
- proc_pid_set_where looks overly changed, and most of the stuff should
  not be there.
- "char buf='testbug';" is that really compiling ?
- p->om.whereto
- too much slabs. I think only the pkt slab is needed.

With smaller documented patches, I may be able to be more specific though.

Cheers,
-- 
Vincent Hanquez

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV