Re: om-2.6 patch for kcomd (pre-alpha)

tab-mTI/[email protected] (Vincent Hanquez)
Newsgroups gmane.linux.cluster.openmosix.devel
Message-ID <[email protected]>
On Fri, Jul 28, 2006 at 12:22:23PM -0600, Matt Dew wrote:
>    In the continuing efforts of a non-programmer to contribute to the
> project, here's my second installation of kcomd patches.
> 
>   Here's another patch for kcomd at
> http://www.osource.org/openmosix/om-26.php.
> 
> Vanilla kernel patch:
> http://www.osource.org/openmosix/patches/om-2.6-full-20060727.patch.bz2
> 
> Patch against git:
> http://www.osource.org/openmosix/patches/om-2.6-git-20060727.patch.bz2

Matt, I tried to do something with the patch (twice), but eventually
gave up, because I have no idea what is useful from what is not.

Please remove all different commented versions of the same code.
Do not comment code that is not useful anymore, just delete it.
Try to split the patch in some small feature:
- patch 1: move function to ..., patch 2: add X functions that does Y
  patch 3: remove dead code in Z, patch 4: convert A to new B ...

That way I can understand what is going on and apply/correct
everything very quickly.

I'll try to give the big patch a shot if I don't see anything coming,
but that would be really helpful to have small patches ...

Cheers,
-- 
Vincent Hanquez

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.