patch comments [1/5]

Florian,
  Nice. Looks like your latest patches addresses the most of the
comments I had on the other patches.

In the documentation patch, socket_listen->sock_create, the error
condition is checked but not printk(KERN_ERR...) is outputted.

Here's some patches, 5 in total, that address some additional things.

This patch removes an unreached else statement int mig_do_receive_home.
ack pkts are dealt with in kcomd so no need to deal with them here.

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

_______________________________________________
openMosix-devel mailing list
openMosix-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/openmosix-devel

--- a/hpc/migrecv.c	2006-09-20 15:43:14.000000000 -0600
+++ b/hpc/migrecv.c	2006-09-22 14:34:17.000000000 -0600
@@ -115,27 +115,6 @@
 			return -1;
 		}
 
-
-	} else {
-		printk("Received MIG_GO_HOME PKT_ACK packet.\n");
-
-		recv_tsk=kcom_task_find(recv_kcom_pkt->rpid);
-		if (!recv_tsk) {
-			printk("Unable to find remote pid %u\n", recv_kcom_pkt->rpid);
-			return -1;
-		}
-
-		// spin_lock(&recv_tsk->spinlock);
-		list_add_tail(&recv_kcom_pkt->list, &recv_tsk->in_packs);
-		// spin_unlock(&recv_tsk->spinlock);
-		sltsk=find_task_by_pid(recv_kcom_pkt->rpid); // only remote node will receive MIG_GO_HOME ack
-		if (sltsk) {
-			printk("Waking up process %u\n", sltsk->pid);
-			wake_up_process(sltsk);
-		} else {
-			printk("Unable to wake up process %u\n", recv_kcom_pkt->rpid);
-			return -1;
-		}
 	}
 
 	return 0;