Re: [patch 3/21] openmosix/openmosix-__kcom_task_find-spinlocks.patch

On Wed, Nov 01, 2006 at 05:10:35AM +0100, Florian Delizy wrote:
> +	read_lock(&tasklist_lock);
>  	p = find_task_by_pid(pid);
> -	// read_unlock(&tasklist_lock);
> +	 read_unlock(&tasklist_lock);

wave ... indentation broken.

> +                read_lock( &kcom_nodes_lock );

it's no kernel style to put spaces after '(' and before ')'

etc...

the same hold for a lots of this patches ... consistant codingstyle is
important.

Cheers,
-- 
Vincent Hanquez

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642