Re: svn/patches?

On Tue, Feb 13, 2007 at 06:26:52PM +0100, Florian Delizy wrote:
> risc-a6VBIPemKmirG/[email protected] wrote:
> > i was just reading through some of the wiki, and thought i'd improve the scripts we're supposed to use.
> >
> > do i post patches here? who do i ask to approve them? what is the chain of approval before they get to SVN?
> >
> >   
>  well you can start by sending the patch to the list, and I'll 
> eventually add it in the svn
> > what do i need to do to get wiki access?
> >   
> create an account ... that's easy
> 
> ;)
> 
well, my account is set up. ;)

heres my first touch.

convert $BASEDIR to an absolute path. this was required for me to use setupenv, but i suspect its because i used a relative path to my build directory.

svn diff
Index: devutils/setupenv
===================================================================
--- devutils/setupenv   (revision 17)
+++ devutils/setupenv   (working copy)
@@ -5,6 +5,12 @@
 BASEDIR="$(dirname $0)/../"
 PRG="$(basename $0)"
 
+# convert $BASEDIR to an absolute path
+PWD=$(pwd)
+cd "$BASEDIR"
+BASEDIR=$(pwd)
+cd $PWD
+
 function CreateEnv()
 {
         if [ -z "$1" -o "help" == "$1" ]; then


is there a page on the wiki about prefered patch submission formats?

on another note, any idea why this patch fails to apply?

Applying patch openmosix/ptrace_check_attach-support.patch
patching file hpc/kcomd.c
Hunk #1 FAILED at 346.
1 out of 1 hunk FAILED -- rejects in file hpc/kcomd.c

Julia Longtin <risc-a6VBIPemKmirG/[email protected]>

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV