Re: svn/patches?

risc-a6VBIPemKmirG/[email protected] wrote:
> On Tue, Feb 13, 2007 at 06:26:52PM +0100, Florian Delizy wrote:
>   
>> risc-a6VBIPemKmirG/[email protected] wrote:
>>     
>>> i was just reading through some of the wiki, and thought i'd improve the scripts we're supposed to use.
>>>
>>> do i post patches here? who do i ask to approve them? what is the chain of approval before they get to SVN?
>>>
>>>   
>>>       
>>  well you can start by sending the patch to the list, and I'll 
>> eventually add it in the svn
>>     
>>> what do i need to do to get wiki access?
>>>   
>>>       
>> create an account ... that's easy
>>
>> ;)
>>
>>     
> well, my account is set up. ;)
>
> heres my first touch.
>
> convert $BASEDIR to an absolute path. this was required for me to use setupenv, but i suspect its because i used a relative path to my build directory.
>
> svn diff
> Index: devutils/setupenv
> ===================================================================
> --- devutils/setupenv   (revision 17)
> +++ devutils/setupenv   (working copy)
> @@ -5,6 +5,12 @@
>  BASEDIR="$(dirname $0)/../"
>  PRG="$(basename $0)"
>  
> +# convert $BASEDIR to an absolute path
> +PWD=$(pwd)
> +cd "$BASEDIR"
> +BASEDIR=$(pwd)
> +cd $PWD
> +
>  function CreateEnv()
>  {
>          if [ -z "$1" -o "help" == "$1" ]; then
>   

I guess pushd/popd would look a bit nicer :) but I'll check that.
>
> is there a page on the wiki about prefered patch submission formats?
>   
well, not yet, but you can do it. Please submit patches attached to 
emails on the list (that will make my life easier).
> on another note, any idea why this patch fails to apply?
>
> Applying patch openmosix/ptrace_check_attach-support.patch
> patching file hpc/kcomd.c
> Hunk #1 FAILED at 346.
> 1 out of 1 hunk FAILED -- rejects in file hpc/kcomd.c
>
>   
I probably didn't finish or forgot to refresh it, I've been scheduled 
out and I am no longer working on oM for now (I am not sure I'll be able 
to get some time on it before a while).

Florian Delizy

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV