Re: openmosixview bugs/issues/wishlist

Hi Hubert,

i agree with (most of) your suggestions ;)


Hubert Chan schrieb:
> Our local Debian group recently set up an openMosix
> cluster, and we are
> using openMosixview as our visualization (i.e. show off)
> tool.  While
> setting up openMosixview, we have identified some bugs,
> and wishlist
> items.  I am also willing to help out with any of these
> issues if
> needed.

:) welcome

> 
> - openmosixcollector should not store its statistics in
> /tmp.  From the
>   FHS, the best place I can see for the stats would be
>   /var/lib/openmosixview.  (Our local version of
> openmosixcollector has
>   been changed to store the stats in
> /var/lib/openmosixview.)

mhmm, ok, i do not like /var/lib/openmosixview so much either.
Also the openMosixWebView looks for the collector files
in /tmp so if we change this Ramon has to adjust his
application too  (or the user has to create sym-links
to make it working).
... will think about it.


> 
> - openmosixcollector should be able to automatically
> delete old (e.g. >
>   7 days old) statistics.  (Alternately, this could be
> handled by a
>   cron script.)

yep

> 
> - openmosixcollector should run as its own separate user
> instead of as
>   root (if possible -- I'm new to openMosix, so I don't
> know if it will
>   be able to collect the statistics if it's not root).

will check

> 
> - openmosixcollector should not output debugging info to
> stdout
>   (especially when in daemon mode).  If it needs to print
> out debugging
>   info, that should be sent to syslog.

agree

> 
> - openmosixview should not use a hardcoded /tmp/nodes.tmp
> filename.  At
>   least it should use a mkstemp(3)-generated file. 
> Ideally it should
>   fork the external process with a redirected stdout, and
> read straight
>   from the process.

agree

> 
> - when generating the date string in openmosixcollector,
> should add 1
>   to the month, since tm_mon is 0-based, but
> human-readable formats are
>   usually 1-based.

agree

> 
> - in most of the files, there are a lot of instances of
> things like
>     "returndate = returndate + ..."
>   where returndate is a string.  It is much better to
> write
>     "returndate += ..."
>   since this should, in general, be faster.

agree too

> 
> That's it for now.  I'm planning on looking through most
> of the code
> later on, and I'll keep you informed of anything else I
> find.

best
... i am sure you will find more  ;)

> 
> Hubert
> 
> 
> 
> -------------------------------------------------------
> This SF. Net email is sponsored by: GoToMyPC
> GoToMyPC is the fast, easy and secure way to access your
> computer from
> any Web browser or wireless device. Click here to Try it
> Free!
>
https://www.gotomypc.com/tr/OSDN/AW/Q4_2003/t/g22lp?Target=mm/g22lp.tmpl
> _______________________________________________
> Mosixview-user mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/mosixview-user
> 


Will care about this wishlist for the next version.
If you have patches/updates available they are 
more than welcome.


Many thanks for your investigations,

Matt


-------------------------------------------------------
This SF. Net email is sponsored by: GoToMyPC
GoToMyPC is the fast, easy and secure way to access your computer from
any Web browser or wireless device. Click here to Try it Free!
https://www.gotomypc.com/tr/OSDN/AW/Q4_2003/t/g22lp?Target=mm/g22lp.tmpl