Re: [SSI] openssi/kernel/ipc msg.c, 1.12, 1.13 sem.c, 1.28, 1.29 shm.c, 1.23, 1.24

Roger Tsang wrote:
> Update of /cvsroot/ssic-linux/openssi/kernel/ipc
> In directory fdv4jf1.ch3.sourceforge.com:/tmp/cvs-serv14613/ipc
>   
...
> -			{
> -				tsma = (char *)kmalloc(sizeof(struct sem_array), GFP_KERNEL);
> -				if (tsma == NULL) break;
> -				memset(tsma, 0, sizeof(struct sem_array));
> -				ssi_sem_get_sem_array(node_num, ipc_id, &tsma);
> -				sma = (struct sem_array *)tsma;
> +			} else {
> +				sma = kzmalloc(sizeof(struct sem_array), GFP_KERNEL);
> +				if (sma == NULL)
> +					break;
> +				(void) ssi_sem_get_sem_array(node_num, ipc_id, (char **) &sma);
>   
The kzmalloc is clearly better than kmalloc/memset, but why zero it out 
at all?  Wouldn't it be better to test the return of ssi_sem_get_sem_array?

Maybe too much like hard work for a not very important function.


------------------------------------------------------------------------------