Re: [comedi] Comedi Driver with LPCIe-7250 problem

On 28/05/2025 13:03, Der Alte wrote:
> Hi Folks, in my 6.4.0 openSuse kernel tree there is a file named=20
> adl_pci_7x3x.c but no adl_pci7230.c, adl_pci7432.c and no adl_pci7250.c=
=20
> like in the github=C2=A0 Linux-CoMeDI repo.

The adl_pci7x3x.c in the kernel sources supports the cards that were=20
previously supported by adl_pci7230.c and adl_pci7432.c, but not=20
adl_pci7250.c.  Support for the {L}PCI{e}-7250 cards is currently=20
missing from the kernel sources, but I plan to port the adl_pci7250=20
driver over from the Linux-CoMeDI repo. (It's only taken me 10 years to=20
get around to it, so far!)  There are some recently discovered=20
incompatibilities with the latest hardware revisions of the LPCIe-7250=20
that need to be resolved first.

> I remember addint Interupt functionality "once" in adl_pci_7x3x.c and=20
> adv_pci_dio.c but can't remember the year in the moment.

You added interrupt handling into those files for the ADLINK PCI-7230=20
and the Advantech PCI-1730 back in early 2021 (kernel version 5.12).

> Was the splitting done after that or before the IRQ add-on?
> Seems like I missed someting.

Hartley Sweeten replaced adl_pci7230.c and adl_pci7432.c with=20
adl_pci7x3x.c in mid 2012 (kernel version 3.7).

> Which concept is the more modern one? One driver for each card type or=20
> the collecting driver for a family of cards?

In general, it depends how similar the cards are at the register level.=20
There is no hard and fast rule.  It's a bit of a judgement call.

--=20
-=3D( Ian Abbott <[email protected]> || MEV Ltd. is a company  )=3D-
-=3D( registered in England & Wales.  Regd. number: 02862268.  )=3D-
-=3D( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=3D-
-=3D( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=3D-

--=20
You received this message because you are subscribed to the Google Groups "=
Comedi: Linux Control and Measurement Device Interface" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to [email protected].
To view this discussion visit https://groups.google.com/d/msgid/comedi_list=
/5820c657-3127-475c-85e8-2f6ddc2eb57e%40mev.co.uk.