QUESTION: kernel/drivers/char/console_macros.h

#define vc_state ....

This particular macro happens to be the SAME NAME as the vconsole data
structure member it references.

This seems quite unhandy if you try to reference the vc_state member using a
pointer to a vconsole data structure like so:

struct vc_data *vcdp = vc_cons[currcons].d;

vcdp->vc_state = whatever...;

The macro will expand (because of course it has the same name and the
preprocessor doesn't know the difference) when what you really wanted was
the structure member.  Cryptic syntax errors result.

So... HERE IS THE QUESTION: was there some compelling reason this particular
macro should be this way, (rather than #define state ...) or was it just
some ages old typo that was never noticed?

Of course, if all you use is the macros to reference vconsole data, the
issue never surfaces - but the resultant code quality suffers when some
function has several macros in it that could benefit from caching a pointer
to the current vcon structure and using that.

-
To unsubscribe from this list: send the line "unsubscribe linux-console" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html