Re: [PATCH] aespipe - fix build issues

Jari Ruusu <[email protected]> Sat, 01 Nov 2008 19:48:36 +0200
Newsgroups gmane.linux.cryptography,gmane.spam.detected
Message-ID <[email protected]>
Alon Bar-Lev wrote:
> This patch contains some fixes to aespipe build:
> 1. Add quotes to AC_DEFUN to configure.ac so autoconf will not complain.
> 2. Add datarootdir to Makefile.in so autoconf will not complain.
> 3. Support DESTDIR make variable to allow standard "make install
>    DESTDIR=/tmp/root", so package manages may use make install.
> 4. Allow separate build directory (mkdir xx; cd xx; ../configure), add
>    srcdir support.
> 5. Add aespipe as dependency for install.

I merged your patch. Thanks.

> If you like I will be very happy to convert current Makefile to automake,
> it would be much easier to maintain.

automake creates it own set of problems, so I am not a big fan of it.
Problems: unreadable generated Makefile and nasty automake version
dependency for people who need to modify Makefile/Makefile.am

-- 
Jari Ruusu  1024R/3A220F51 5B 4B F9 BB D3 3F 52 E9  DB 1D EB E3 24 0E A9 DD

-
Linux-crypto:  cryptography in and on the Linux system
Archive:       http://mail.nl.linux.org/linux-crypto/