Re: [PATCH 1/4] dm-crypt: clarify cipher vs. cipher mode

On 12/28/2009 07:59 PM, Max Vozeler wrote:
> The original code used cc->cipher for two things:

> @@ -1014,6 +1014,7 @@ static int crypt_ctr(struct dm_target *ti, unsigned int argc, char **argv)
>  	char *ivopts;
>  	unsigned int key_size;
>  	unsigned long long tmpll;
> +	char ciphermode[CRYPTO_MAX_ALG_NAME];

Today is CRYPTO_MAX_ALG_NAME 64 bytes but it can increase in future.
This should not be allocated on the stack.

But anyway, I see that the reason for this is to introduce multikey feature
(compatible with loop-AES mode). That's interesting idea.

But please can you add more explanation into documentation about this mode?
Is there any paper which analyses that mode - if so can you add link
to description?
(and yes, I know loop-AES documentation:-)

Milan
--
[email protected]
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html