Re: Bug in mask_proc (repost)

John Ogness <[email protected]> Sat, 21 Nov 2009 09:01:25 +0100
Newsgroups gmane.linux.dazuko.devel
Message-ID <[email protected]>
On 2009-11-19, Lino Sanfilippo <[email protected]> wrote:
> This is a repost of a patch that I posted on 9th July 2009. This
> time the patch is for the recent dazukofs version (3.1.1).
>
> The problem is that there is a (dazukofs_proc) structure allocated
> on the stack and afterwards put in a global list. This will very
> likely leed to problems sooner or later, since the stack memory may
> be overwritten the next time the proc structure is accessed in the
> list.

Please specify an example code path in Linux proving the problem can
occur.

In my opinion you are fixing a problem that does not exist and instead
are creating an extra (expensive) malloc for every file access.

John Ogness

-- 
Dazuko Maintainer