Re: rasdaemon_0.8.1-3~bpo12+1_amd64.changes REJECTED

Hi Vasudev,

On 07.11.24 04:49, Vasudev Kamath wrote:
> Micha Lenk<[email protected]>  writes:
>> The changes are not minimal. The reason for dropping the dh_installsystemd
>> invocation is unclear from reading the debian/changelog.
> Reason to drop it is its breaking when building for bookworm with its
> debhelper version 13.11.4.

If it wasn't because of debhelper, this could even be a legitimate 
change. Still I'd expect to include this reason in debian/changelog 
(which is something different than describing what I can see also in the 
debdiff output).

>> Now this same thing works fine if I pin the debhelper to
>> bookwrom-backports version or the version in unstable. I'm not exactly
>> sure what went in between these to cause such breakage.
If the debhelper version available in bookworm is not recent enough to 
build successfully, you should express this with a properly versioned 
dependency (already in unstable/testing).
>> If you think depending on bookworm-backports debhelper is right way I can do that.. Let me know.

Yes, for debhelper we generally prefer to use a more recent version from 
bookworm-backports over changing anything else.

For other build dependencies this is more a judgement call. In general, 
please feel free to ask for guidance on the mailing list in advance in 
case you need help with such a judgement call. We're happy to help.

Kind regards,
Micha