Re: reform-tools_1.82-2~bpo13+1_both.changes REJECTED

Nicholas D Steeves <[email protected]> Sat, 06 Dec 2025 15:22:07 -0500
Newsgroups	gmane.linux.debian.backports.general
Message-ID	<[email protected]>
Hi Johannes,

Johannes Schauer Marin Rodrigues <[email protected]> writes:

> Hi Nicholas,
>
> thank you for reaching out and offering help!

You're welcome!

> Quoting Nicholas D Steeves (2025-12-06 00:22:05)
>> Johannes Schauer Marin Rodrigues <[email protected]> writes:
>> > Quoting Micha Lenk (2025-12-05 16:01:20)
>> >> d/p/reform-power-daemon.patch certainly is a good idea, but it isn't
>> >> mentioned in debian/changelog. Please document all the changes you did in
>> >> debian/changelog.
>> 
>> This will only take a line or two and shouldn't take more than a couple
>> of seconds to fix.  When the package in testing is in a sufficiently good
>> state then I'm confident that a backport of it will be accepted.
>
> maybe I'm really dumb and please assume I am because I might be missing
> something really obvious. I am unable to find the file
> reform-power-daemon.patch anywhere. It is certainly not part of version
> 1.82-2. In fact there are no patches at all:
>
> https://sources.debian.org/src/reform-tools/1.82-2/debian
>
> And the topmost changelog "Rebuild for trixie-backports." is really just that.
> There are no other changes than the changelog entry. At least there should be.
> I don't understand what I am missing.
>
> I am finding reform-power-daemon.patch in my shell history but it is not part
> of my local packaging git. I haven't pushed the debian/trixie-backports branch
> to salsa but my git does not know about the file. "git log -p | grep
> reform-power-daemon.patch" comes back empty...
>
> Any ideas?

This is an interesting mystery, and no, you're not dumb.  I'm going to
assume that you're not using a dgit-style "patches-applied" Debian
packaging branch in the analysis below:

Here's what we know:

  1. A Debian Backports ftpmaster knows about reform-power-daemon.patch.
  2. That ftpmaster looked at a source package you uploaded.
  :. Thus this patch was part of your upload.

  3. That file doesn't exist in any copy of the packaging anymore.
  4. That file isn't checked into git in any local or remote branch.
  :. That file was probably never checked into git, or a git reset
     --hard wiped out.

If you checkout a patch-queue/suite-name branch you might be able to
find the git commit that was gbp exported to generate
reform-power-daemon.patch.  I suspect that this was work that didn't
reach a natural checkpoint or milestone, or else was interrupted before
it could be checked into git.  If you were working with quilt directly,
then the evidence of now gone (unless you want to restore from backup).

Do you still have access to the source package that you uploaded to
mentors?  Or maybe a copy from a backup?  That would be the fastest way
to proceed.  Finally, here are the three most likely causes imho:

  reform-power-daemon.patch is work that was destined for 1.82-2, but a
  `gbp export` didn't occur, or the manually created quilt series wasn't
  checked-in, so the work was never part of a source package, and was
  accidentally included in the backport.

or

  reform-power-daemon.patch is work that was destined for 1.82-3 and was
  accidentally included in the backport.

or

  reform-power-daemon.patch is specific to the trixie-backport, and
  1.82-2~bpo won't work properly without it; meanwhile 1.82-2 in sid and
  testing works fine.


I hope this is enough to figure out what happened.
Regards,
Nicholas
signature.asc (application/pgp-signature, 857 B)