Re: Bug#1029843: brcmfmac: requested firmware filename inconsistent with linux-firmware.git on non-devicetree systems

Hi,

Diederik de Haas <[email protected]> (2023-05-04):
> Assuming the '55' stands for max 55 chars, that could be an issue?

That's not how format strings work. :)

That happily overflows:

    $ printf "%-10s and the rest of the line\n" kibi
    kibi       and the rest of the line

    $ printf "%-10s and the rest of the line\n" "Diederik de Haas"
    Diederik de Haas and the rest of the line

> It turns out that spaces (and or backslashes to escape them) seems to
> be an issue for the Debian scripts used to make the Debian
> firmware-nonfree packages too. See https://bugs.debian.org/1035505 for
> details. Once that is fixed, I can submit my MR to add those missing
> symlinks.

Oh, d-i isn't the only one expecting non-crazy paths! :)

> Seems doable. I'm not going to spend time trying to make that though.
> I know virtually nothing about d-i/hw-detect internals, so it seems
> very unwise for me to even try it.
> Given the (specific) subject at hand, you won't be surprised that
> there's also a motivational issue ;-)

I was merely writing it out so that it could be sanity-checked, I wasn't
suggesting you would be the one to implement that. (Instead, I was
implicitly volunteering myself…)


Cheers,
-- 
Cyril Brulebois ([email protected])            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEtg6/KYRFPHDXTPR4/5FK8MKzVSAFAmRT7EgACgkQ/5FK8MKz
VSAwaQ//TEtJts16NF52jvVT63s2vEXNZ7LJhZ3Wn7tf1JKSRQdjWs5qH6JVrkPX
lWuM5WSuLuuGyG4gvkuk2g1d/2WPCbspZPBYrZUHiaedKo1NQ01+i42GgSWVzj5d
Fj2nY9Cjbi9aZXuDLfgkjh0CljpA3SkObb/XUPsjChixVDm4JMkQfDedIc1PQkY2
H40EQv3LaXAEgiT4Mpwu2WwiIftRJ9n3A3G2jb3CazGDfRySVJ4BA/Z6lmYF0igI
2uZbfuxQmOc27mw2dF7XoOdKPxVKvx7Qk9LD3BG8KftFvg9FYuaxTLQcWtA5hJGh
LlToBX29LPj+/pvecVXayfRr7fVC18muA1uuEngbVGPUyrvP54rXDsdddx9a6Lb5
lHv6Fx9Yl2SfWxhYpYR+wdNVfQvKIvESWwz2L0KXkAOWOILT8TYCL1lfvSZnUfLx
oK+xrIdlFDac3zBcQ82hqIJW0ICj2Lp6jfM0GFn7Nn9fDAxA0+dSx5IP1FN/kktL
BwaxPAiCFftO3E/QC8aw+er+arGEl8YZczGKdDGN0JEd6cRqyv4h9JV3kBoucE+V
KNSmLRnRbraoTKcawoc3EmuzWiMRSMcFADpTXPMI9ZFvSGa/Mf6rv/UhiXXPVeNe
i2kCi6pqO0d3KpjAAt+pzT3Srsg0GeauZqrUSwlifAVbWoWjCWs=
=ybkJ
-----END PGP SIGNATURE-----