Bug#815342: MTA failures, if $config{subscription_domain} is defined as "" (empty string)

Package: debbugs
Severity: normal
Version: 2.6.0~exp1
Tags: patch

Hi,

On my debbugs instance, the variable

$gSubscriptionDomain = "";		# e.g. packages.qa.debian.org

is defined as an empty string.

With that setting, I have been experiencing regular MTA failures (that  
I have always ignored on bugs.x2go.org) when debbugs tries to send  
mails to <package>@<subscription_domain>.

The failures look like these:

"""
The message WAS NOT relayed to:
   <nxagent@>: [127.0.0.1] said:
    501 5.1.3 id=18759-04-3 - Rejected by MTA on relaying, from  
MTA([127.0.0.1]:10025): 501 5.1.3 Bad recipient address syntax
"""

The issue can be solved in Debbugs::Recipient:

"""
diff --git a/Debbugs/Recipients.pm b/Debbugs/Recipients.pm
index ae739e9..36430e7 100644
--- a/Debbugs/Recipients.pm
+++ b/Debbugs/Recipients.pm
@@ -116,7 +116,8 @@ sub add_recipients {
       my $ref = $param{data}{bug_num};
       for my $p (splitpackages($param{data}{package})) {
           $p = lc($p);
-         if (defined $config{subscription_domain}) {
+         if (defined $config{subscription_domain} and
+             length $config{subscription_domain}) {
                my @source_packages = binary_to_source(binary => $p,
                                                       source_only => 1,
                                                      );
"""

Greets,
Mike
-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: [email protected], http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/mailxchange/kronolith/fb.php?u=m.gabriel%40das-netzwerkteam.de

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJWyOe2AAoJEJr0azAldxsxSDoP/3tc7mRlg7gjyizEZy8qm8VT
w1R6jZFaaXjnYqhNrMlaXJv0eaMKO+qhQttAlVPbfxYWtVga17L/4dwOawYeZN0j
hxVwWI18WT6yQ8+N8hv+6TqD3gvawf4DsznM0PinlnFuuOn+GksDFzSyPGGntxZ9
amNtHH/2iCxNlgc25ugm26mp9mbAPj7k2VqFDflkBNFfwlhZaCIO/bwSE8WNEqIx
YuxdJBiJ/2xYvexbzGw4f5tCp1H5gOGX1kRpGXSDJ+11PsBjvUSwhGLN5h3/nlIx
UsDxR1pKcyFd1Ite5GXr866fv7s8IH9BSvZUUU+IyBk0tFBNJts4IpDmhASttfMD
jaFgY0akIOFAl/RUhKpFyCnSZcLjgtpcekWrEsyTd0usJ84Uu3pccQWx/Y3SDqiV
GsklHGCcNZuO4gfChtub+7/JpxYd5AZAp1QfJpSp33ncebdaIpEDf1JGp8qv6EpL
ni5waYWLuCMX1dK+/HbdH1es6VyN20zjPnYY5dKEULGYGPObCEE/PqcFJ8dspQ6V
SrTmBV9tkhW37qpzKfLyqA1hMrOJQLhNZ8IvqNBpxOwQoSg4OD1BNWtA9z+x5xv8
QqIHxsegoSS1gaZtuuD0P2mcDdWKpVhgaziaKQyQMBpTkLmi2X7CQqh+0BJ1NbDl
1z5q97RhQG/PqVE6Ly6w
=9DrF
-----END PGP SIGNATURE-----