Bug#622934: marked as done (local-debbugs: missing newline at end of "'/etc/debbugs/config' doesn't exist" message)

"Debian Bug Tracking System" <[email protected]> Sun, 15 Dec 2024 21:57:03 +0000
Newsgroups gmane.linux.debian.devel.debbugs
Message-ID <[email protected]>
This is a multi-part message in MIME format...

------------=_1734299823-704550-0
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

Your message dated Sun, 15 Dec 2024 22:55:26 +0100
with message-id <Z19QTh8J_B6XRtK0@seventeen>
and subject line Re: Bug#622934: local-debbugs: missing newline at end of "=
'/etc/debbugs/config' doesn't exist" message
has caused the Debian Bug report #622934,
regarding local-debbugs: missing newline at end of "'/etc/debbugs/config' d=
oesn't exist" message
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


--=20
622934: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D622934
Debian Bug Tracking System
Contact [email protected] with problems

------------=_1734299823-704550-0
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at submit) by bugs.debian.org; 15 Apr 2011 23:12:09 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.1-bugs.debian.org_2005_01_02
	(2010-03-16) on busoni.debian.org
X-Spam-Level: 
X-Spam-Status: No, score=-8.9 required=4.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,HAS_PACKAGE,IMPRONONCABLE_2,
	MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham
	version=3.3.1-bugs.debian.org_2005_01_02
X-Spam-Bayes: score:0.0000 Tokens: new, 21; hammy, 129; neutral, 42; spammy,
	0. spammytokens: hammytokens:0.000-+--H*u:2010-09-15,
	0.000-+--H*UA:2010-09-15, 0.000-+--H*u:1.5.21, 0.000-+--H*UA:1.5.21,
	0.000-+--Severity
Return-path: <[email protected]>
Received: from mail-iy0-f180.google.com ([209.85.210.180])
	by busoni.debian.org with esmtps (TLS1.0:RSA_ARCFOUR_MD5:16)
	(Exim 4.72)
	(envelope-from <[email protected]>)
	id 1QAsBM-00043H-RR
	for [email protected]; Fri, 15 Apr 2011 23:12:09 +0000
Received: by iyf40 with SMTP id 40so4414160iyf.11
        for <[email protected]>; Fri, 15 Apr 2011 16:12:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:date:from:to:subject:message-id:mime-version
         :content-type:content-disposition:user-agent;
        bh=W/jH4vsp1e48Thko4xPCwLn4mg76OWeoOzKSvJg6eSc=;
        b=Y+kkSmzamHu0ZlesRYlWWLFo7wLmioux8U2ynAJbwMTqYx7txWluxlsBu1mPLNQHJX
         5FhzRhDEBLtAjUAUsW1zvZdKZhIMQPINC3E3gpSAOMLaFxjqqm3WkMEsFj7vDIIxwXki
         88ggG60GPNZ1DPoLtRpv+PpiGrh3KGLNm8O74=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:subject:message-id:mime-version:content-type
         :content-disposition:user-agent;
        b=flKFhjF5svvJCNw87isVhudfhiY5yejHWZRszAUDGWQv0ch6JWzxV4keCNbAFAWjLr
         /pWzR+1V01au3vlQRCxWRGWkk+rtZ2FAVAxmMQnr9351ZNpOa2xdVPM02dHPdh0GlsIQ
         y4PAjvyQIoURrmnGDrjboDA0gwOa26F3pHEk8=
Received: by 10.43.64.82 with SMTP id xh18mr3366444icb.65.1302909121945;
        Fri, 15 Apr 2011 16:12:01 -0700 (PDT)
Received: from elie (adsl-69-209-64-230.dsl.chcgil.sbcglobal.net [69.209.64.230])
        by mx.google.com with ESMTPS id uk4sm1738960icb.9.2011.04.15.16.11.59
        (version=SSLv3 cipher=OTHER);
        Fri, 15 Apr 2011 16:12:01 -0700 (PDT)
Date: Fri, 15 Apr 2011 18:11:53 -0500
From: Jonathan Nieder <[email protected]>
To: [email protected]
Subject: local-debbugs: missing newline at end of "'/etc/debbugs/config'
 doesn't exist" message
Message-ID: <20110415231153.GA20654@elie>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.21 (2010-09-15)
Delivered-To: [email protected]

Package: libdebbugs-perl
Version: 2.4.2~exp1
Severity: minor
Justification: cosmetic
Tags: patch

Hi,

Trying local-debbugs again.  How about this patch?

-- 8< --
Subject: Add missing newline to (! -e $conf_file) message

The message reporting that /etc/debbugs/config doesn't exist is
missing a trailing newline.  Noticed because it runs into the
next message when trying out debbugs-local for the first time.

 $ local-debbugs --mirror
 configuration file '/etc/debbugs/config' doesn't exist; skipping itRsyncing bugs
 [...]

Signed-off-by: Jonathan Nieder <[email protected]>
---
 Debbugs/Config.pm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Debbugs/Config.pm b/Debbugs/Config.pm
index ae4c04f..d5a928d 100644
--- a/Debbugs/Config.pm
+++ b/Debbugs/Config.pm
@@ -1025,7 +1025,7 @@ set_default(\%config,'html_expire_note',
 sub read_config{
      my ($conf_file) = @_;
      if (not -e $conf_file) {
-	 print STDERR "configuration file '$conf_file' doesn't exist; skipping it";
+	 print STDERR "configuration file '$conf_file' doesn't exist; skipping it\n";
 	 return;
      }
      # first, figure out what type of file we're reading in.
-- 
1.7.5.rc2




------------=_1734299823-704550-0
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at 622934-done) by bugs.debian.org; 15 Dec 2024 21:55:47 +0000
X-Spam-Checker-Version: SpamAssassin 3.4.6-bugs.debian.org_2005_01_02
	(2021-04-09) on buxtehude.debian.org
X-Spam-Level: 
X-Spam-Status: No, score=-10.8 required=4.0 tests=BAYES_00,FROMDEVELOPER,
	HAS_BUG_NUMBER,HEADER_FROM_DIFFERENT_DOMAINS,MD5_SHA1_SUM,
	SPF_HELO_NONE,SPF_PASS,VERSION autolearn=ham autolearn_force=no
	version=3.4.6-bugs.debian.org_2005_01_02
X-Spam-Bayes: score:0.0000 Tokens: new, 23; hammy, 150; neutral, 39; spammy,
	0. spammytokens: hammytokens:0.000-+--exp1, 0.000-+--53pm,
	0.000-+--53PM, 0.000-+--H*F:U*ballombe,
	0.000-+--Hx-spam-relays-external:debian.org
Return-path: <[email protected]>
Received: from podman-shm1.math.u-bordeaux1.fr ([147.210.21.11]:52312)
	by buxtehude.debian.org with esmtps (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)
	(Exim 4.94.2)
	(envelope-from <[email protected]>)
	id 1tMwaY-002xDD-Rz
	for [email protected]; Sun, 15 Dec 2024 21:55:47 +0000
Received: from smtp-in.math.u-bordeaux.fr (host.containers.internal [147.210.21.11])
	by podman-shm1.math.u-bordeaux1.fr (Postfix) with ESMTPS id AC602516C1;
	Sun, 15 Dec 2024 22:55:42 +0100 (CET)
Received: from smtp.math.u-bordeaux.fr (host.containers.internal [147.210.21.11])
	by smtp-in.math.u-bordeaux.fr (Postfix) with ESMTPS id A2A4B51730;
	Sun, 15 Dec 2024 22:55:42 +0100 (CET)
Received: from seventeen (88-167-68-207.subs.proxad.net [88.167.68.207])
	by smtp.math.u-bordeaux.fr (Postfix) with ESMTPSA id 5BC01516C1;
	Sun, 15 Dec 2024 22:55:42 +0100 (CET)
Date: Sun, 15 Dec 2024 22:55:26 +0100
From: Bill Allombert <[email protected]>
To: Jonathan Nieder <[email protected]>, [email protected]
Subject: Re: Bug#622934: local-debbugs: missing newline at end of
 "'/etc/debbugs/config' doesn't exist" message
Message-ID: <Z19QTh8J_B6XRtK0@seventeen>
References: <20110415231153.GA20654@elie>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110415231153.GA20654@elie>

Version: 2.6.0

On Fri, Apr 15, 2011 at 06:11:53PM -0500, Jonathan Nieder wrote:
> Package: libdebbugs-perl
> Version: 2.4.2~exp1
> Severity: minor
> Justification: cosmetic
> Tags: patch
> 
> Hi,
> 
> Trying local-debbugs again.  How about this patch?
> 
>  sub read_config{
>       my ($conf_file) = @_;
>       if (not -e $conf_file) {
> -	 print STDERR "configuration file '$conf_file' doesn't exist; skipping it";
> +	 print STDERR "configuration file '$conf_file' doesn't exist; skipping it\n";
>  	 return;
>       }
>       # first, figure out what type of file we're reading in.

Hello Jonathan,

This was fixed in 2.6.0 in this commit

commit 621ee75bb7ca185b1d428fa606d5d31c44c19e0d
Author: Don Armstrong <[email protected]>
Date:   Tue Jan 17 22:16:06 2012 -0800

    test for equality, and only complain about the conffile missing if debug is set

Cheers,